issue_comments

Table actions

12 rows where author_association = "MEMBER" and issue = 396501063 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

issue 1

  • to_dict without data · 12 ✖

author_association 1

  • MEMBER · 12 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
462909530 https://github.com/pydata/xarray/pull/2659#issuecomment-462909530 https://api.github.com/repos/pydata/xarray/issues/2659 MDEyOklzc3VlQ29tbWVudDQ2MjkwOTUzMA== rabernat 1197350 2019-02-12T19:53:58Z 2019-02-12T19:53:58Z MEMBER

p.s. I learned about this from @kwilcox in https://github.com/pangeo-data/pangeo-datastore/issues/3. He might be a good person to loop into this discussion.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   to_dict without data 396501063
462901810 https://github.com/pydata/xarray/pull/2659#issuecomment-462901810 https://api.github.com/repos/pydata/xarray/issues/2659 MDEyOklzc3VlQ29tbWVudDQ2MjkwMTgxMA== rabernat 1197350 2019-02-12T19:33:10Z 2019-02-12T19:33:10Z MEMBER 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   to_dict without data 396501063
461178889 https://github.com/pydata/xarray/pull/2659#issuecomment-461178889 https://api.github.com/repos/pydata/xarray/issues/2659 MDEyOklzc3VlQ29tbWVudDQ2MTE3ODg4OQ== rabernat 1197350 2019-02-06T20:40:15Z 2019-02-06T20:40:15Z MEMBER 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   to_dict without data 396501063
456185803 https://github.com/pydata/xarray/pull/2659#issuecomment-456185803 https://api.github.com/repos/pydata/xarray/issues/2659 MDEyOklzc3VlQ29tbWVudDQ1NjE4NTgwMw== shoyer 1217238 2019-01-21T20:04:49Z 2019-01-21T20:04:49Z MEMBER

I think we should merge this -- @rabernat feel free to go ahead and do that.

We can leave data='coords' for a follow-up, if anyone has real use-cases for it.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   to_dict without data 396501063
455553874 https://github.com/pydata/xarray/pull/2659#issuecomment-455553874 https://api.github.com/repos/pydata/xarray/issues/2659 MDEyOklzc3VlQ29tbWVudDQ1NTU1Mzg3NA== rabernat 1197350 2019-01-18T13:55:56Z 2019-01-18T13:55:56Z MEMBER

Let's get this merged?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   to_dict without data 396501063
453471377 https://github.com/pydata/xarray/pull/2659#issuecomment-453471377 https://api.github.com/repos/pydata/xarray/issues/2659 MDEyOklzc3VlQ29tbWVudDQ1MzQ3MTM3Nw== fmaussion 10050469 2019-01-11T10:29:22Z 2019-01-14T22:12:04Z MEMBER

Maybe we could change it so that attrs is only included if it is non-empty.

How do people feel about this? If folks are fine with it as is, then LGTM.

I'd rather have an empty dict as in the current implementation (like xarray)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   to_dict without data 396501063
453432847 https://github.com/pydata/xarray/pull/2659#issuecomment-453432847 https://api.github.com/repos/pydata/xarray/issues/2659 MDEyOklzc3VlQ29tbWVudDQ1MzQzMjg0Nw== rabernat 1197350 2019-01-11T08:44:25Z 2019-01-11T08:44:25Z MEMBER

Maybe we could change it so that attrs is only included if it is non-empty.

How do people feel about this? If folks are fine with it as is, then LGTM.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   to_dict without data 396501063
452475599 https://github.com/pydata/xarray/pull/2659#issuecomment-452475599 https://api.github.com/repos/pydata/xarray/issues/2659 MDEyOklzc3VlQ29tbWVudDQ1MjQ3NTU5OQ== dcherian 2448579 2019-01-08T22:30:44Z 2019-01-08T22:30:44Z MEMBER

Does this help with #2347?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   to_dict without data 396501063
452219508 https://github.com/pydata/xarray/pull/2659#issuecomment-452219508 https://api.github.com/repos/pydata/xarray/issues/2659 MDEyOklzc3VlQ29tbWVudDQ1MjIxOTUwOA== rabernat 1197350 2019-01-08T08:48:03Z 2019-01-08T08:48:03Z MEMBER

Here is what the .to_dict(data=False) output looks like from the test example

python x = np.random.randn(10) y = np.random.randn(10) t = list('abcdefghij') ds = Dataset(OrderedDict([('a', ('t', x)), ('b', ('t', y)), ('t', ('t', t))])) ds.to_dict(data=False)

{'attrs': {}, 'coords': {'t': {'attrs': {}, 'dims': ('t',), 'dtype': '<U1', 'shape': (10,)}}, 'data_vars': {'a': {'attrs': {}, 'dims': ('t',), 'dtype': 'float64', 'shape': (10,)}, 'b': {'attrs': {}, 'dims': ('t',), 'dtype': 'float64', 'shape': (10,)}}, 'dims': {'t': 10}}

The one thing I don't like about this is the empty attributes. Maybe we could change it so that attrs is only included if it is non-empty. Alternatively, we coiuld add a squeeze_attrs option.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   to_dict without data 396501063
452064456 https://github.com/pydata/xarray/pull/2659#issuecomment-452064456 https://api.github.com/repos/pydata/xarray/issues/2659 MDEyOklzc3VlQ29tbWVudDQ1MjA2NDQ1Ng== shoyer 1217238 2019-01-07T20:06:55Z 2019-01-07T20:06:55Z MEMBER

What other attribute than dtype were you thinking about?

Shape might also be a good idea.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   to_dict without data 396501063
452048428 https://github.com/pydata/xarray/pull/2659#issuecomment-452048428 https://api.github.com/repos/pydata/xarray/issues/2659 MDEyOklzc3VlQ29tbWVudDQ1MjA0ODQyOA== fmaussion 10050469 2019-01-07T19:16:05Z 2019-01-07T19:16:05Z MEMBER

It just occurred to me that it would be nice to have some extra info about the data, such as dtype.

II was about to ask about it ;-). What other attribute than dtype were you thinking about?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   to_dict without data 396501063
452020337 https://github.com/pydata/xarray/pull/2659#issuecomment-452020337 https://api.github.com/repos/pydata/xarray/issues/2659 MDEyOklzc3VlQ29tbWVudDQ1MjAyMDMzNw== rabernat 1197350 2019-01-07T17:49:03Z 2019-01-07T17:49:03Z MEMBER

It just occurred to me that it would be nice to have some extra info about the data, such as dtype.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   to_dict without data 396501063

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);