home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 453471377

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/2659#issuecomment-453471377 https://api.github.com/repos/pydata/xarray/issues/2659 453471377 MDEyOklzc3VlQ29tbWVudDQ1MzQ3MTM3Nw== 10050469 2019-01-11T10:29:22Z 2019-01-14T22:12:04Z MEMBER

Maybe we could change it so that attrs is only included if it is non-empty.

How do people feel about this? If folks are fine with it as is, then LGTM.

I'd rather have an empty dict as in the current implementation (like xarray)

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  396501063
Powered by Datasette · Queries took 0.755ms · About: xarray-datasette