issue_comments

Table actions

4 rows where author_association = "MEMBER" and issue = 385716625 sorted by updated_at descending

✖
✖
✖

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 3

issue 1

  • Keep attributes across operations · 4 ✖

author_association 1

  • MEMBER · 4 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
443786550 https://github.com/pydata/xarray/issues/2582#issuecomment-443786550 https://api.github.com/repos/pydata/xarray/issues/2582 MDEyOklzc3VlQ29tbWVudDQ0Mzc4NjU1MA== dcherian 2448579 2018-12-03T17:04:24Z 2018-12-03T17:04:24Z MEMBER

Hi @MBlaschek, almost there! You'll need to open your pull request in this repository :).

You'll also need to add some tests to make sure your changes keep working as the code is updated in the future. E.g. https://github.com/pydata/xarray/blob/0d6056e8816e3d367a64f36c7f1a5c4e1ce4ed4e/xarray/tests/test_variable.py#L1533

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Keep attributes across operations 385716625
443286361 https://github.com/pydata/xarray/issues/2582#issuecomment-443286361 https://api.github.com/repos/pydata/xarray/issues/2582 MDEyOklzc3VlQ29tbWVudDQ0MzI4NjM2MQ== dcherian 2448579 2018-11-30T17:57:47Z 2018-11-30T17:57:47Z MEMBER

@MBlaschek This might help: https://help.github.com/articles/proposing-changes-to-your-work-with-pull-requests/ . You'd start by creating a fork, then a branch with your changes, push your changes to github and then initiate a pull request.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Keep attributes across operations 385716625
443285132 https://github.com/pydata/xarray/issues/2582#issuecomment-443285132 https://api.github.com/repos/pydata/xarray/issues/2582 MDEyOklzc3VlQ29tbWVudDQ0MzI4NTEzMg== max-sixty 5635139 2018-11-30T17:53:48Z 2018-11-30T17:53:48Z MEMBER

Not sure what a PR is. (Sorry I'm not that advanced in coding)

PR is a pull-request! If you can open a PR with your code, we can merge it to the repo. Would be greatly appreciated from xarray, and you'd be an xarray contributor. Let us know if we can help guide you through the mechanics.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Keep attributes across operations 385716625
442975920 https://github.com/pydata/xarray/issues/2582#issuecomment-442975920 https://api.github.com/repos/pydata/xarray/issues/2582 MDEyOklzc3VlQ29tbWVudDQ0Mjk3NTkyMA== shoyer 1217238 2018-11-29T20:09:29Z 2018-11-29T20:09:29Z MEMBER

Thanks for the report! It looks like we definitely overlooked this in arithmetic operations. I agree that keep_attrs=True should mean that attributes are maintained in arithmetic.

Any interest in putting together a PR? - https://github.com/pydata/xarray/pull/2482 has lots of examples of how to implement the option. - https://github.com/pydata/xarray/blob/0d6056e8816e3d367a64f36c7f1a5c4e1ce4ed4e/xarray/core/variable.py#L1665 is where we forget to keep attributes in binary operations.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Keep attributes across operations 385716625

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);