issue_comments: 442975920

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/2582#issuecomment-442975920 https://api.github.com/repos/pydata/xarray/issues/2582 442975920 MDEyOklzc3VlQ29tbWVudDQ0Mjk3NTkyMA== 1217238 2018-11-29T20:09:29Z 2018-11-29T20:09:29Z MEMBER

Thanks for the report! It looks like we definitely overlooked this in arithmetic operations. I agree that keep_attrs=True should mean that attributes are maintained in arithmetic.

Any interest in putting together a PR? - https://github.com/pydata/xarray/pull/2482 has lots of examples of how to implement the option. - https://github.com/pydata/xarray/blob/0d6056e8816e3d367a64f36c7f1a5c4e1ce4ed4e/xarray/core/variable.py#L1665 is where we forget to keep attributes in binary operations.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   385716625