issue_comments

Table actions

8 rows where author_association = "MEMBER" and issue = 354324342 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

issue 1

  • Adding data kwarg to copy to create new objects with same structure as original · 8 ✖

author_association 1

  • MEMBER · 8 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
422535898 https://github.com/pydata/xarray/pull/2384#issuecomment-422535898 https://api.github.com/repos/pydata/xarray/issues/2384 MDEyOklzc3VlQ29tbWVudDQyMjUzNTg5OA== max-sixty 5635139 2018-09-18T20:14:04Z 2018-09-18T20:14:04Z MEMBER

Thank you v much @jsignell ! Both for the excellent code and for bearing with the changes!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Adding data kwarg to copy to create new objects with same structure as original 354324342
422473891 https://github.com/pydata/xarray/pull/2384#issuecomment-422473891 https://api.github.com/repos/pydata/xarray/issues/2384 MDEyOklzc3VlQ29tbWVudDQyMjQ3Mzg5MQ== shoyer 1217238 2018-09-18T17:10:46Z 2018-09-18T17:10:46Z MEMBER

If we're all happy with copy (which I think we are), then this should be good to go!

 
{
    "total_count": 2,
    "+1": 2,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Adding data kwarg to copy to create new objects with same structure as original 354324342
421177555 https://github.com/pydata/xarray/pull/2384#issuecomment-421177555 https://api.github.com/repos/pydata/xarray/issues/2384 MDEyOklzc3VlQ29tbWVudDQyMTE3NzU1NQ== shoyer 1217238 2018-09-13T22:53:32Z 2018-09-13T22:53:32Z MEMBER

template.copy(data=new_data)? That seems pretty clear, actually.

 
{
    "total_count": 2,
    "+1": 2,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Adding data kwarg to copy to create new objects with same structure as original 354324342
421171894 https://github.com/pydata/xarray/pull/2384#issuecomment-421171894 https://api.github.com/repos/pydata/xarray/issues/2384 MDEyOklzc3VlQ29tbWVudDQyMTE3MTg5NA== fujiisoup 6815844 2018-09-13T22:23:43Z 2018-09-13T22:23:43Z MEMBER

how about + dataarray_like / variable_like + copy_labels ?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Adding data kwarg to copy to create new objects with same structure as original 354324342
421171706 https://github.com/pydata/xarray/pull/2384#issuecomment-421171706 https://api.github.com/repos/pydata/xarray/issues/2384 MDEyOklzc3VlQ29tbWVudDQyMTE3MTcwNg== max-sixty 5635139 2018-09-13T22:22:44Z 2018-09-13T22:22:44Z MEMBER

Sorry I'm late to the party here. @jsignell thank you for the PR!

Pandas has something similar: the ._shallow_copy method, which accepts optional data to replace the current data.

Ambitious suggestion: given that we already create shallow copies when copying, could data become an optional arg to copy? I realize it's may be a little surprising to change all the data and still call it a copy, but there's precedent.

Less ambitious: I'd vote to have this as a method. I'm generally partial to methods given their discoverability and namespaces-without-cost. I think the context is clear. OTOH there is precedent with ones_like et al.

Naming: I'd vote labelled_like > structured_like, but not strongly

That said, given my timing, I'd understand if we go forward as-is

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Adding data kwarg to copy to create new objects with same structure as original 354324342
419480046 https://github.com/pydata/xarray/pull/2384#issuecomment-419480046 https://api.github.com/repos/pydata/xarray/issues/2384 MDEyOklzc3VlQ29tbWVudDQxOTQ4MDA0Ng== shoyer 1217238 2018-09-07T15:40:53Z 2018-09-07T15:40:53Z MEMBER

More ideas: - xarray.copy_structure(template, new_data) - xarray.structured_like(new_data, template) - xarray.copy_labels(template, new_data)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Adding data kwarg to copy to create new objects with same structure as original 354324342
419476614 https://github.com/pydata/xarray/pull/2384#issuecomment-419476614 https://api.github.com/repos/pydata/xarray/issues/2384 MDEyOklzc3VlQ29tbWVudDQxOTQ3NjYxNA== shoyer 1217238 2018-09-07T15:29:40Z 2018-09-07T15:29:40Z MEMBER

What about a DataArray method called replace_data or with_data? e.g., data_array.replace_data(new_data) or data_array.with_data(new_data).

We could also make a more general DataArray.replace method (inspired by collections.namedtuple._replace) that lets you replace any of data, coords, dims, attrs or encoding on a top object. Then this would look like data_array.replace(new_data) or data_array.replace(attrs=new_attrs). Replacing name or dims could invoke the rename() method.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Adding data kwarg to copy to create new objects with same structure as original 354324342
419318366 https://github.com/pydata/xarray/pull/2384#issuecomment-419318366 https://api.github.com/repos/pydata/xarray/issues/2384 MDEyOklzc3VlQ29tbWVudDQxOTMxODM2Ng== dcherian 2448579 2018-09-07T04:22:18Z 2018-09-07T04:22:41Z MEMBER

LGTM. I'm not a big fan of the name though, but I can't think of a better one. I wonder if we should have dataarray_like and variable_like that call _label_like.

Also, this needs additions to whats-new.rst and api.rst.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Adding data kwarg to copy to create new objects with same structure as original 354324342

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);