issue_comments

Table actions

2 rows where author_association = "MEMBER", issue = 315381649 and user = 1197350 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • rabernat · 2 ✖

issue 1

  • open_mfdataset can't handle many files · 2 ✖

author_association 1

  • MEMBER · 2 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
382449451 https://github.com/pydata/xarray/issues/2066#issuecomment-382449451 https://api.github.com/repos/pydata/xarray/issues/2066 MDEyOklzc3VlQ29tbWVudDM4MjQ0OTQ1MQ== rabernat 1197350 2018-04-18T16:34:22Z 2018-04-18T16:34:22Z MEMBER

@pgierz, thanks for volunteering! We would love to see a PR from you. I agree that this should be a pretty simple fix. The error gets raised here I believe: https://github.com/pydata/xarray/blob/master/xarray/backends/api.py#L565-L566

As is often the case, creating a test for this will probably be harder than resolving the issue itself!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   open_mfdataset can't handle many files 315381649
382383934 https://github.com/pydata/xarray/issues/2066#issuecomment-382383934 https://api.github.com/repos/pydata/xarray/issues/2066 MDEyOklzc3VlQ29tbWVudDM4MjM4MzkzNA== rabernat 1197350 2018-04-18T13:21:07Z 2018-04-18T13:21:07Z MEMBER

I don’t think we should change the default, at it may have unintended consequences.

I DO think we should catch this specific error and recommend to the user to try autoclose=True in the error message.

On Apr 18, 2018, at 5:47 AM, Paul Gierz notifications@github.com wrote:

That seemed to do the trick. Would it be worthwhile to consider putting the default value of autoclose=True in the method definition, or would that induce other problems?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread. 

{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   open_mfdataset can't handle many files 315381649

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);