home / github / issue_comments

Menu
  • GraphQL API
  • Search all tables

issue_comments: 382383934

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/2066#issuecomment-382383934 https://api.github.com/repos/pydata/xarray/issues/2066 382383934 MDEyOklzc3VlQ29tbWVudDM4MjM4MzkzNA== 1197350 2018-04-18T13:21:07Z 2018-04-18T13:21:07Z MEMBER

I don’t think we should change the default, at it may have unintended consequences.

I DO think we should catch this specific error and recommend to the user to try autoclose=True in the error message.

On Apr 18, 2018, at 5:47 AM, Paul Gierz notifications@github.com wrote:

That seemed to do the trick. Would it be worthwhile to consider putting the default value of autoclose=True in the method definition, or would that induce other problems?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  315381649
Powered by Datasette · Queries took 1.875ms · About: xarray-datasette