issue_comments

Table actions

3 rows where author_association = "MEMBER", issue = 297631403 and user = 1217238 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • shoyer · 3 ✖

issue 1

  • h5netcdf new API support · 3 ✖

author_association 1

  • MEMBER · 3 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
387264547 https://github.com/pydata/xarray/pull/1915#issuecomment-387264547 https://api.github.com/repos/pydata/xarray/issues/1915 MDEyOklzc3VlQ29tbWVudDM4NzI2NDU0Nw== shoyer 1217238 2018-05-08T02:25:51Z 2018-05-08T02:25:51Z MEMBER

Thanks @crusaderky !

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   h5netcdf new API support 297631403
384339399 https://github.com/pydata/xarray/pull/1915#issuecomment-384339399 https://api.github.com/repos/pydata/xarray/issues/1915 MDEyOklzc3VlQ29tbWVudDM4NDMzOTM5OQ== shoyer 1217238 2018-04-25T15:57:51Z 2018-04-25T15:57:51Z MEMBER

Generally looks great.

What if both zlib=True and compression='lzf' is set in encoding? This could potentially happen, e.g., if reading from a file with zlib encoding and attempting to write as lzf. I think the compression argument should take a precedence, but we should add a test case to verify that this works.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   h5netcdf new API support 297631403
377296855 https://github.com/pydata/xarray/pull/1915#issuecomment-377296855 https://api.github.com/repos/pydata/xarray/issues/1915 MDEyOklzc3VlQ29tbWVudDM3NzI5Njg1NQ== shoyer 1217238 2018-03-29T16:41:52Z 2018-03-29T16:41:52Z MEMBER

@crusaderky Yes, I like the look of that better. It's slightly unfortunate that it's taking a while for the netCDF4 library to figure this out so it's not clear the API will be yet. We might not want to keep the separate new API backend with h5netcdf in the long term, but we certainly would not remove/deprecate it until everything is supported with the legacy API.

One minor concern is the name. I don't know what h5netcdf-ng stands for ("next generation?"). I would prefer h5netcdf-new.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   h5netcdf new API support 297631403

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);