issue_comments: 384339399

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/1915#issuecomment-384339399 https://api.github.com/repos/pydata/xarray/issues/1915 384339399 MDEyOklzc3VlQ29tbWVudDM4NDMzOTM5OQ== 1217238 2018-04-25T15:57:51Z 2018-04-25T15:57:51Z MEMBER

Generally looks great.

What if both zlib=True and compression='lzf' is set in encoding? This could potentially happen, e.g., if reading from a file with zlib encoding and attempting to write as lzf. I think the compression argument should take a precedence, but we should add a test case to verify that this works.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   297631403