issue_comments

Table actions

11 rows where author_association = "MEMBER" and issue = 297631403 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 3

issue 1

  • h5netcdf new API support · 11 ✖

author_association 1

  • MEMBER · 11 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
387264547 https://github.com/pydata/xarray/pull/1915#issuecomment-387264547 https://api.github.com/repos/pydata/xarray/issues/1915 MDEyOklzc3VlQ29tbWVudDM4NzI2NDU0Nw== shoyer 1217238 2018-05-08T02:25:51Z 2018-05-08T02:25:51Z MEMBER

Thanks @crusaderky !

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   h5netcdf new API support 297631403
386912485 https://github.com/pydata/xarray/pull/1915#issuecomment-386912485 https://api.github.com/repos/pydata/xarray/issues/1915 MDEyOklzc3VlQ29tbWVudDM4NjkxMjQ4NQ== crusaderky 6213168 2018-05-06T20:50:12Z 2018-05-06T20:50:12Z MEMBER

@shoyer all green and ready for merge

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   h5netcdf new API support 297631403
385596906 https://github.com/pydata/xarray/pull/1915#issuecomment-385596906 https://api.github.com/repos/pydata/xarray/issues/1915 MDEyOklzc3VlQ29tbWVudDM4NTU5NjkwNg== jhamman 2443309 2018-05-01T04:32:18Z 2018-05-01T04:32:18Z MEMBER

closing/reopening seemed to do the trick for @stickler-ci. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   h5netcdf new API support 297631403
385084034 https://github.com/pydata/xarray/pull/1915#issuecomment-385084034 https://api.github.com/repos/pydata/xarray/issues/1915 MDEyOklzc3VlQ29tbWVudDM4NTA4NDAzNA== jhamman 2443309 2018-04-27T20:22:45Z 2018-04-27T20:22:45Z MEMBER

@crusaderky - sometimes these just need a nudge. Can you try closing/reopening the PR or pushing another commit. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   h5netcdf new API support 297631403
385082069 https://github.com/pydata/xarray/pull/1915#issuecomment-385082069 https://api.github.com/repos/pydata/xarray/issues/1915 MDEyOklzc3VlQ29tbWVudDM4NTA4MjA2OQ== crusaderky 6213168 2018-04-27T20:14:43Z 2018-04-27T20:14:43Z MEMBER

@shoyer / @jhamman , stickler-ci has been pending for a day now - I'm afraid it should be pronounced dead

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   h5netcdf new API support 297631403
384781418 https://github.com/pydata/xarray/pull/1915#issuecomment-384781418 https://api.github.com/repos/pydata/xarray/issues/1915 MDEyOklzc3VlQ29tbWVudDM4NDc4MTQxOA== crusaderky 6213168 2018-04-26T20:38:59Z 2018-04-26T20:38:59Z MEMBER

@shoyer done

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   h5netcdf new API support 297631403
384339399 https://github.com/pydata/xarray/pull/1915#issuecomment-384339399 https://api.github.com/repos/pydata/xarray/issues/1915 MDEyOklzc3VlQ29tbWVudDM4NDMzOTM5OQ== shoyer 1217238 2018-04-25T15:57:51Z 2018-04-25T15:57:51Z MEMBER

Generally looks great.

What if both zlib=True and compression='lzf' is set in encoding? This could potentially happen, e.g., if reading from a file with zlib encoding and attempting to write as lzf. I think the compression argument should take a precedence, but we should add a test case to verify that this works.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   h5netcdf new API support 297631403
383754358 https://github.com/pydata/xarray/pull/1915#issuecomment-383754358 https://api.github.com/repos/pydata/xarray/issues/1915 MDEyOklzc3VlQ29tbWVudDM4Mzc1NDM1OA== crusaderky 6213168 2018-04-23T23:29:02Z 2018-04-23T23:29:02Z MEMBER

@shoyer finished and ready for final code review and integration

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   h5netcdf new API support 297631403
381441984 https://github.com/pydata/xarray/pull/1915#issuecomment-381441984 https://api.github.com/repos/pydata/xarray/issues/1915 MDEyOklzc3VlQ29tbWVudDM4MTQ0MTk4NA== crusaderky 6213168 2018-04-15T22:08:41Z 2018-04-15T22:08:41Z MEMBER

Almost finished - only one outstanding unit test failure when specifying the "chunks" parameter

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   h5netcdf new API support 297631403
377296855 https://github.com/pydata/xarray/pull/1915#issuecomment-377296855 https://api.github.com/repos/pydata/xarray/issues/1915 MDEyOklzc3VlQ29tbWVudDM3NzI5Njg1NQ== shoyer 1217238 2018-03-29T16:41:52Z 2018-03-29T16:41:52Z MEMBER

@crusaderky Yes, I like the look of that better. It's slightly unfortunate that it's taking a while for the netCDF4 library to figure this out so it's not clear the API will be yet. We might not want to keep the separate new API backend with h5netcdf in the long term, but we certainly would not remove/deprecate it until everything is supported with the legacy API.

One minor concern is the name. I don't know what h5netcdf-ng stands for ("next generation?"). I would prefer h5netcdf-new.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   h5netcdf new API support 297631403
366097048 https://github.com/pydata/xarray/pull/1915#issuecomment-366097048 https://api.github.com/repos/pydata/xarray/issues/1915 MDEyOklzc3VlQ29tbWVudDM2NjA5NzA0OA== jhamman 2443309 2018-02-15T23:28:50Z 2018-02-15T23:28:50Z MEMBER

@crusaderky - if you sync with master, you'll stop getting the stickler-ci messages. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   h5netcdf new API support 297631403

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);