issue_comments

Table actions

2 rows where author_association = "MEMBER" and issue = 278122300 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 2

issue 1

  • _FillValue and missing_value not allowed for the same variable · 2 ✖

author_association 1

  • MEMBER · 2 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
348635463 https://github.com/pydata/xarray/issues/1749#issuecomment-348635463 https://api.github.com/repos/pydata/xarray/issues/1749 MDEyOklzc3VlQ29tbWVudDM0ODYzNTQ2Mw== jhamman 2443309 2017-12-01T22:52:13Z 2017-12-01T22:52:13Z MEMBER

A practical downside to masking both values is that we won't be able to round-trip the two part fill/missing value. Once everything is a NaN, that's all we get. That said, I'm personally fine with masking both.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   _FillValue and missing_value not allowed for the same variable 278122300
348374694 https://github.com/pydata/xarray/issues/1749#issuecomment-348374694 https://api.github.com/repos/pydata/xarray/issues/1749 MDEyOklzc3VlQ29tbWVudDM0ODM3NDY5NA== shoyer 1217238 2017-12-01T01:27:43Z 2017-12-01T01:27:43Z MEMBER

I can certainly see a case for taking a more relaxed approach to _FillValue and missing_value, e.g., masking on both rather than raising an error. I'm not sure that it's actually more user friendly to ignore missing_value for masking.

This part of xarray is very old (added in https://github.com/pydata/xarray/pull/245), before almost anyone outside Climate Corporation was using it. So I'm certainly open to revisiting this, but let's make sure we get the decision right this time.

Does anyone else with lots of experience with different netCDF files have opinions here? Maybe @dopplershift?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   _FillValue and missing_value not allowed for the same variable 278122300

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);