issue_comments

Table actions

4 rows where author_association = "MEMBER" and issue = 262966657 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

issue 1

  • pynio backend broken in python 3 · 4 ✖

author_association 1

  • MEMBER · 4 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
334534517 https://github.com/pydata/xarray/issues/1611#issuecomment-334534517 https://api.github.com/repos/pydata/xarray/issues/1611 MDEyOklzc3VlQ29tbWVudDMzNDUzNDUxNw== jhamman 2443309 2017-10-05T17:25:11Z 2017-10-05T17:25:11Z MEMBER

Yep, it sounds like you have it about right. Why don't you open a PR and we can iterate further there.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   pynio backend broken in python 3 262966657
334513337 https://github.com/pydata/xarray/issues/1611#issuecomment-334513337 https://api.github.com/repos/pydata/xarray/issues/1611 MDEyOklzc3VlQ29tbWVudDMzNDUxMzMzNw== jhamman 2443309 2017-10-05T16:07:10Z 2017-10-05T16:07:10Z MEMBER

@brhillman - A PR to fix the iteritems issue can happen now. You could also add a test to the allowed_failures section: https://github.com/pydata/xarray/blob/c748062ef4353f5e249553b06a198a44c71083c4/.travis.yml#L42-L61

that pulls the ncar dev build down. That would allow us to work out some of the kinks while they get their final python3 release ready.

More broadly, if we don't have a viable way to install the package, perhaps your effort would be better spent helping PyNio get Python3 into a full release. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   pynio backend broken in python 3 262966657
334340087 https://github.com/pydata/xarray/issues/1611#issuecomment-334340087 https://api.github.com/repos/pydata/xarray/issues/1611 MDEyOklzc3VlQ29tbWVudDMzNDM0MDA4Nw== jhamman 2443309 2017-10-05T02:15:05Z 2017-10-05T02:15:05Z MEMBER

One PR is fine. I don't think you'll need to add any tests, just add pynio to the conda environment file I linked to above and the existing test base should run for python 3 with pynio.

We may need to ping @ocefpaf to help us get a conda-forge build of pynio for python3 repo.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   pynio backend broken in python 3 262966657
334323641 https://github.com/pydata/xarray/issues/1611#issuecomment-334323641 https://api.github.com/repos/pydata/xarray/issues/1611 MDEyOklzc3VlQ29tbWVudDMzNDMyMzY0MQ== jhamman 2443309 2017-10-05T00:06:06Z 2017-10-05T02:12:33Z MEMBER

@brhillman - that would be great. I don't think anyone has worked on this yet and we'd be happy to have you contribute here.

We have some contributor guidelines in the works (see #1485).

Generally, we'll want to add the pynio package to one or more of the python3 test suites (here would be a good place to start).

Put your changes on a branch (e.g. feature/python3_pynio), run the test suite (py.test), follow pep8 formatting, and then push to your fork and open a PR. The template checklist in the PRs helps us make sure we're catching the main things.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   pynio backend broken in python 3 262966657

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);