issues: 262966657
This data as json
| id | node_id | number | title | user | state | locked | assignee | milestone | comments | created_at | updated_at | closed_at | author_association | active_lock_reason | draft | pull_request | body | reactions | performed_via_github_app | state_reason | repo | type |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 262966657 | MDU6SXNzdWUyNjI5NjY2NTc= | 1611 | pynio backend broken in python 3 | 15826727 | closed | 0 | 11 | 2017-10-04T23:57:22Z | 2017-10-06T02:05:52Z | 2017-10-06T02:05:52Z | CONTRIBUTOR | pynio recently released a development python 3 port (see https://github.com/NCAR/pynio/issues/10). The pynio backend in xarray needs a slight fix to use this though; the get_variables() method in the NioDataStore class tries to access the iteritems() method of the variables object, which no longer exists in python3. The simple fix is to replace iteritems() with items() in this method. I've made this fix on a local version of the code, and it seems to work as expected. I would be happy to put together a PR if nobody has done such, and if someone could point me to any documentation or recommendations on the preferred conventions for structuring PRs for the project (I have not contributed before). Thanks! |
{
"url": "https://api.github.com/repos/pydata/xarray/issues/1611/reactions",
"total_count": 1,
"+1": 1,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} |
completed | 13221727 | issue |