issue_comments

Table actions

5 rows where author_association = "MEMBER" and issue = 251734482 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 2

issue 1

  • Add `pathlib.Path` support to `open_(mf)dataset` · 5 ✖

author_association 1

  • MEMBER · 5 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
326611618 https://github.com/pydata/xarray/pull/1514#issuecomment-326611618 https://api.github.com/repos/pydata/xarray/issues/1514 MDEyOklzc3VlQ29tbWVudDMyNjYxMTYxOA== shoyer 1217238 2017-09-01T15:31:59Z 2017-09-01T15:31:59Z MEMBER

CI failures are all the issue with dask distributed (https://github.com/pydata/xarray/issues/1540), so I'm going ahead and merging.

Thanks @willirath !

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add `pathlib.Path` support to `open_(mf)dataset` 251734482
324971323 https://github.com/pydata/xarray/pull/1514#issuecomment-324971323 https://api.github.com/repos/pydata/xarray/issues/1514 MDEyOklzc3VlQ29tbWVudDMyNDk3MTMyMw== shoyer 1217238 2017-08-25T16:31:20Z 2017-08-25T16:31:20Z MEMBER

And then I remove the pathlib2 dependency I've introduced in setup.py again?

Yes, pathlib2 should not be a required dependency.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add `pathlib.Path` support to `open_(mf)dataset` 251734482
324969407 https://github.com/pydata/xarray/pull/1514#issuecomment-324969407 https://api.github.com/repos/pydata/xarray/issues/1514 MDEyOklzc3VlQ29tbWVudDMyNDk2OTQwNw== shoyer 1217238 2017-08-25T16:23:28Z 2017-08-25T16:23:28Z MEMBER

@willirath take a look at what we do for handling the optional dask dependency: https://github.com/pydata/xarray/blob/bcd608101133c0cb84c74d341d22edef71ef4818/xarray/core/pycompat.py#L55-L60

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add `pathlib.Path` support to `open_(mf)dataset` 251734482
323845017 https://github.com/pydata/xarray/pull/1514#issuecomment-323845017 https://api.github.com/repos/pydata/xarray/issues/1514 MDEyOklzc3VlQ29tbWVudDMyMzg0NTAxNw== max-sixty 5635139 2017-08-21T20:30:48Z 2017-08-21T20:30:48Z MEMBER

Curently, tests with Python 2 are failing, because there is no explicit pathlib dependency yet.

I missed this, apologies.

Can we add pathlib2 as an optional dependency and handle the case where it's not installed?

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add `pathlib.Path` support to `open_(mf)dataset` 251734482
323844395 https://github.com/pydata/xarray/pull/1514#issuecomment-323844395 https://api.github.com/repos/pydata/xarray/issues/1514 MDEyOklzc3VlQ29tbWVudDMyMzg0NDM5NQ== max-sixty 5635139 2017-08-21T20:27:58Z 2017-08-21T20:27:58Z MEMBER

Are you sure pathlib exists in py2? I had thought you needed to install pathlib2 (I may be wrong on the specifics)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add `pathlib.Path` support to `open_(mf)dataset` 251734482

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);