issue_comments

Table actions

5 rows where author_association = "MEMBER" and issue = 229807027 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 2

issue 1

  • Speed up `decode_cf_datetime` · 5 ✖

author_association 1

  • MEMBER · 5 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
317814176 https://github.com/pydata/xarray/pull/1414#issuecomment-317814176 https://api.github.com/repos/pydata/xarray/issues/1414 MDEyOklzc3VlQ29tbWVudDMxNzgxNDE3Ng== jhamman 2443309 2017-07-25T17:42:58Z 2017-07-25T17:43:19Z MEMBER

Thanks @cchwala! I think the Pandas issue is sufficient on this one.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Speed up `decode_cf_datetime` 229807027
317055124 https://github.com/pydata/xarray/pull/1414#issuecomment-317055124 https://api.github.com/repos/pydata/xarray/issues/1414 MDEyOklzc3VlQ29tbWVudDMxNzA1NTEyNA== jhamman 2443309 2017-07-21T16:56:52Z 2017-07-21T16:56:52Z MEMBER

Agreed. Let's leave the overflow fix for later. I'll give this one more review and we'll try to get this merged.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Speed up `decode_cf_datetime` 229807027
317036076 https://github.com/pydata/xarray/pull/1414#issuecomment-317036076 https://api.github.com/repos/pydata/xarray/issues/1414 MDEyOklzc3VlQ29tbWVudDMxNzAzNjA3Ng== shoyer 1217238 2017-07-21T15:44:15Z 2017-07-21T15:44:15Z MEMBER

Do you want to merge this PR, knowing that there still is the overflow issue that was in the code before?

This still sounds like an improvement to me!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Speed up `decode_cf_datetime` 229807027
315859360 https://github.com/pydata/xarray/pull/1414#issuecomment-315859360 https://api.github.com/repos/pydata/xarray/issues/1414 MDEyOklzc3VlQ29tbWVudDMxNTg1OTM2MA== jhamman 2443309 2017-07-17T19:38:03Z 2017-07-17T19:38:03Z MEMBER

@cchwala - thanks for keeping this moving. Once you've taking another pass at the code and added a Whatsnew note, I'll give it a final review.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Speed up `decode_cf_datetime` 229807027
315206339 https://github.com/pydata/xarray/pull/1414#issuecomment-315206339 https://api.github.com/repos/pydata/xarray/issues/1414 MDEyOklzc3VlQ29tbWVudDMxNTIwNjMzOQ== jhamman 2443309 2017-07-13T21:24:02Z 2017-07-13T21:24:02Z MEMBER

@cchwala - Any update on the testing / overflow issue you mentioned?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Speed up `decode_cf_datetime` 229807027

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);