issues: 229807027

This data as json

id node_id number title user state locked assignee milestone comments created_at updated_at closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
229807027 MDExOlB1bGxSZXF1ZXN0MTIxMzc5NjAw 1414 Speed up `decode_cf_datetime` 102827 closed 0     12 2017-05-18T21:15:40Z 2017-07-26T07:40:24Z 2017-07-25T17:42:52Z CONTRIBUTOR   0 pydata/xarray/pulls/1414
  • [x] Closes #1399
  • [x] Tests added / passed
  • [x] Passes git diff upstream/master | flake8 --diff
  • [x] Fully documented, including whats-new.rst for all changes and api.rst for new API

Instead of casting the input numeric dates to float, they are now casted to nanoseconds as int64 which makes pd.to_timedelta() work much faster (x100 speedup on my machine).

On my machine all existing tests for conventions.py pass. Overflows should be handled by these two already existing lines since everything in the valid range of pd.to_datetime should be save.

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/1414/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     13221727 pull

Links from other tables