issue_comments

Table actions

12 rows where author_association = "MEMBER" and issue = 225222227 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 2

issue 1

  • Sortby · 12 ✖

author_association 1

  • MEMBER · 12 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
301153738 https://github.com/pydata/xarray/pull/1389#issuecomment-301153738 https://api.github.com/repos/pydata/xarray/issues/1389 MDEyOklzc3VlQ29tbWVudDMwMTE1MzczOA== shoyer 1217238 2017-05-12T18:36:30Z 2017-05-12T18:36:30Z MEMBER

BTW, I think I messed up my co-worker's name in whats-new.rst. The spelling is right (Kyle Heuton), but the extra indentation shouldn't be there. As a result his name appears a bit out of place. Would be very much obliged if you could fix that in your next push to master. Gracias.

No worries, whats-new.rst usually requires a fix-up before each release

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Sortby 225222227
300951935 https://github.com/pydata/xarray/pull/1389#issuecomment-300951935 https://api.github.com/repos/pydata/xarray/issues/1389 MDEyOklzc3VlQ29tbWVudDMwMDk1MTkzNQ== shoyer 1217238 2017-05-12T00:29:42Z 2017-05-12T00:29:42Z MEMBER

api.rst should've been a checklist item :)

Indeed, I will add it right now!

Thanks for your contribution!!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Sortby 225222227
300852820 https://github.com/pydata/xarray/pull/1389#issuecomment-300852820 https://api.github.com/repos/pydata/xarray/issues/1389 MDEyOklzc3VlQ29tbWVudDMwMDg1MjgyMA== shoyer 1217238 2017-05-11T17:01:30Z 2017-05-11T17:01:30Z MEMBER

One last thing -- this needs an entry in docs/api.rst in order for the doc page to get built.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Sortby 225222227
300680230 https://github.com/pydata/xarray/pull/1389#issuecomment-300680230 https://api.github.com/repos/pydata/xarray/issues/1389 MDEyOklzc3VlQ29tbWVudDMwMDY4MDIzMA== shoyer 1217238 2017-05-11T04:38:19Z 2017-05-11T04:38:19Z MEMBER

It's very strange that fake8 complains about non-Python files. I think you can safely ignore those. On Wed, May 10, 2017 at 8:55 PM chunweiyuan notifications@github.com wrote:

git diff upstream/master | flake8 --diff only complains about a bunch of lines in whats-new.rst and reshaping.rst. But these complaints don't make any sense to me. Some examples:

doc/reshaping.rst:195:1: E112 expected an indented block doc/reshaping.rst:203:1: E101 indentation contains mixed spaces and tabs doc/reshaping.rst:203:1: W191 indentation contains tabs doc/reshaping.rst:203:2: E113 unexpected indentation

I've played around with it a bit but not seen any changes to the complaints. What is going on? Should I even worry about the .rst files?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/pydata/xarray/pull/1389#issuecomment-300675689, or mute the thread https://github.com/notifications/unsubscribe-auth/ABKS1qjB4dK0tHLBMrX6sURnlt_T5QX0ks5r4obPgaJpZM4NMGMU . 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Sortby 225222227
300599953 https://github.com/pydata/xarray/pull/1389#issuecomment-300599953 https://api.github.com/repos/pydata/xarray/issues/1389 MDEyOklzc3VlQ29tbWVudDMwMDU5OTk1Mw== shoyer 1217238 2017-05-10T20:16:49Z 2017-05-10T20:16:49Z MEMBER

Scroll to the top of this PR and look at your first post :)

On Wed, May 10, 2017 at 11:08 AM, chunweiyuan notifications@github.com wrote:

I just made some futile attempts to find that checklist, to no avail. Mind helping me with a link? :)

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/pydata/xarray/pull/1389#issuecomment-300566860, or mute the thread https://github.com/notifications/unsubscribe-auth/ABKS1mF7Jjb2NmZ_5LZpRvUP_nwG-khgks5r4f0hgaJpZM4NMGMU . 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Sortby 225222227
300561177 https://github.com/pydata/xarray/pull/1389#issuecomment-300561177 https://api.github.com/repos/pydata/xarray/issues/1389 MDEyOklzc3VlQ29tbWVudDMwMDU2MTE3Nw== shoyer 1217238 2017-05-10T17:48:37Z 2017-05-10T17:48:37Z MEMBER

Today is the first time I've heard of flake8.

It's in the checklist for every new PR :).

Is this how you guys standardize quality checks?

Yes. It would be nice to run this as a continuous integration test but we haven't set that up that.

Running it once with either Python 2 or 3 is fine -- it should give the same output either way.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Sortby 225222227
300552112 https://github.com/pydata/xarray/pull/1389#issuecomment-300552112 https://api.github.com/repos/pydata/xarray/issues/1389 MDEyOklzc3VlQ29tbWVudDMwMDU1MjExMg== shoyer 1217238 2017-05-10T17:18:54Z 2017-05-10T17:18:54Z MEMBER

@chunweiyuan have you run flake8 on this?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Sortby 225222227
300292452 https://github.com/pydata/xarray/pull/1389#issuecomment-300292452 https://api.github.com/repos/pydata/xarray/issues/1389 MDEyOklzc3VlQ29tbWVudDMwMDI5MjQ1Mg== shoyer 1217238 2017-05-09T20:32:10Z 2017-05-09T20:32:10Z MEMBER

Ah, good to know.

In that case, let's add a check for dtype == object based on numpy.__version__ (search for LooseVersion for examples in the xarray codebase) and raise an informative NotImplementedError when necessary.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Sortby 225222227
300269107 https://github.com/pydata/xarray/pull/1389#issuecomment-300269107 https://api.github.com/repos/pydata/xarray/issues/1389 MDEyOklzc3VlQ29tbWVudDMwMDI2OTEwNw== shoyer 1217238 2017-05-09T19:02:43Z 2017-05-09T19:02:43Z MEMBER

If I downgrade to numpy 1.10, I get that error. Once upgraded to 1.12, it goes away......

Does it work on numpy 1.11?

We could potentially (partially) drop compatibility for older numpy releases. Or if we can identify the issue, we can raise an informative error or use a work-around.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Sortby 225222227
300030799 https://github.com/pydata/xarray/pull/1389#issuecomment-300030799 https://api.github.com/repos/pydata/xarray/issues/1389 MDEyOklzc3VlQ29tbWVudDMwMDAzMDc5OQ== shoyer 1217238 2017-05-09T00:52:59Z 2017-05-09T00:52:59Z MEMBER

Looks like one the Travis-CI tests failing on the sortby tests: https://travis-ci.org/pydata/xarray/jobs/229457729#L342

It's not immediately clear to me what's going on there, but maybe it's an issue with the old version of NumPy? The error is TypeError: merge sort not available for item 0.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Sortby 225222227
298371922 https://github.com/pydata/xarray/pull/1389#issuecomment-298371922 https://api.github.com/repos/pydata/xarray/issues/1389 MDEyOklzc3VlQ29tbWVudDI5ODM3MTkyMg== shoyer 1217238 2017-05-01T16:49:43Z 2017-05-01T16:49:43Z MEMBER

Indeed, please ignore the first CI build on Travis. For some inexplicable reason it is installing the pandas 0.20rc, which is failing due to https://github.com/pydata/xarray/issues/1386.

I am slightly in favor of sortby but also could go either way. The PEP8 guidance on function/method naming is "lowercase with words separated by underscores as necessary to improve readability." I don't think an underscore is necessary for readability here.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Sortby 225222227
298162358 https://github.com/pydata/xarray/pull/1389#issuecomment-298162358 https://api.github.com/repos/pydata/xarray/issues/1389 MDEyOklzc3VlQ29tbWVudDI5ODE2MjM1OA== max-sixty 5635139 2017-04-29T11:05:30Z 2017-04-29T11:05:30Z MEMBER

We want this as sortby, rather than sort_by? Generally the latter would be more idiomatic, but if there is prior sortby out there, I would vote for consistency

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Sortby 225222227

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);