issue_comments

Table actions

3 rows where author_association = "MEMBER" and issue = 217660739 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 1

issue 1

  • Marks slow, flaky, and failing tests · 3 ✖

author_association 1

  • MEMBER · 3 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
292434454 https://github.com/pydata/xarray/pull/1336#issuecomment-292434454 https://api.github.com/repos/pydata/xarray/issues/1336 MDEyOklzc3VlQ29tbWVudDI5MjQzNDQ1NA== shoyer 1217238 2017-04-07T04:36:08Z 2017-04-07T04:36:08Z MEMBER

If slow tests are being run by default, I'm not sure they really need their own special option. You can mark them (with @pytest.mark.slow) and use pytest's builtin selectors to not run them: pytest -m "not slow".

Yes, this is a good idea.

Are flaky tests actually flaky or do they just not work? If flaky, and a re-run will help, then maybe try the pytest-rerunfailures plugin.

Thanks for pointing this out! I'm not entirely sure pytest-rerunfailures is a fit here but it's a good option to know about.

The tests are flaky on Travis-CI, but they are reliable when run locally, and we still want to keep them around as integration tests. These are slow tests that open and close quite a lot of files (2000 each).

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Marks slow, flaky, and failing tests 217660739
291051992 https://github.com/pydata/xarray/pull/1336#issuecomment-291051992 https://api.github.com/repos/pydata/xarray/issues/1336 MDEyOklzc3VlQ29tbWVudDI5MTA1MTk5Mg== shoyer 1217238 2017-04-03T05:30:23Z 2017-04-03T05:30:23Z MEMBER

Thanks @pwolfram!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Marks slow, flaky, and failing tests 217660739
290255222 https://github.com/pydata/xarray/pull/1336#issuecomment-290255222 https://api.github.com/repos/pydata/xarray/issues/1336 MDEyOklzc3VlQ29tbWVudDI5MDI1NTIyMg== shoyer 1217238 2017-03-29T23:18:01Z 2017-03-29T23:18:01Z MEMBER

@pwolfram Thanks for putting this together.

"Slow" tests on Travis aren't a huge problem -- it takes at least a minute for Travis to complete even in the best case scenario, so having to wait a minute more is not so bad. It's really an issue for interactive, local development, where it's really valuable for tests to complete in less than 10 seconds.

Flaky tests, which fail sometimes, are the problem. So think we want a different category for these many file tests, maybe "Flaky". Ideally we would have an another Travis-CI job setup to run these that isn't required to always pass, like our existing jobs for testing development versions of other libraries.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Marks slow, flaky, and failing tests 217660739

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);