issue_comments

Table actions

13 rows where issue = 217660739 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 3

author_association 2

issue 1

  • Marks slow, flaky, and failing tests · 13 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
292434454 https://github.com/pydata/xarray/pull/1336#issuecomment-292434454 https://api.github.com/repos/pydata/xarray/issues/1336 MDEyOklzc3VlQ29tbWVudDI5MjQzNDQ1NA== shoyer 1217238 2017-04-07T04:36:08Z 2017-04-07T04:36:08Z MEMBER

If slow tests are being run by default, I'm not sure they really need their own special option. You can mark them (with @pytest.mark.slow) and use pytest's builtin selectors to not run them: pytest -m "not slow".

Yes, this is a good idea.

Are flaky tests actually flaky or do they just not work? If flaky, and a re-run will help, then maybe try the pytest-rerunfailures plugin.

Thanks for pointing this out! I'm not entirely sure pytest-rerunfailures is a fit here but it's a good option to know about.

The tests are flaky on Travis-CI, but they are reliable when run locally, and we still want to keep them around as integration tests. These are slow tests that open and close quite a lot of files (2000 each).

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Marks slow, flaky, and failing tests 217660739
292432314 https://github.com/pydata/xarray/pull/1336#issuecomment-292432314 https://api.github.com/repos/pydata/xarray/issues/1336 MDEyOklzc3VlQ29tbWVudDI5MjQzMjMxNA== QuLogic 302469 2017-04-07T04:26:02Z 2017-04-07T04:26:02Z CONTRIBUTOR

If slow tests are being run by default, I'm not sure they really need their own special option. You can mark them (with @pytest.mark.slow) and use pytest's builtin selectors to not run them: pytest -m "not slow".

Are flaky tests actually flaky or do they just not work? If flaky, and a re-run will help, then maybe try the pytest-rerunfailures plugin.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Marks slow, flaky, and failing tests 217660739
291051992 https://github.com/pydata/xarray/pull/1336#issuecomment-291051992 https://api.github.com/repos/pydata/xarray/issues/1336 MDEyOklzc3VlQ29tbWVudDI5MTA1MTk5Mg== shoyer 1217238 2017-04-03T05:30:23Z 2017-04-03T05:30:23Z MEMBER

Thanks @pwolfram!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Marks slow, flaky, and failing tests 217660739
291018928 https://github.com/pydata/xarray/pull/1336#issuecomment-291018928 https://api.github.com/repos/pydata/xarray/issues/1336 MDEyOklzc3VlQ29tbWVudDI5MTAxODkyOA== pwolfram 4295853 2017-04-02T22:12:28Z 2017-04-02T22:12:28Z CONTRIBUTOR

@shoyer, all checks pass and this is ready for a review / merge when you have time.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Marks slow, flaky, and failing tests 217660739
290988338 https://github.com/pydata/xarray/pull/1336#issuecomment-290988338 https://api.github.com/repos/pydata/xarray/issues/1336 MDEyOklzc3VlQ29tbWVudDI5MDk4ODMzOA== pwolfram 4295853 2017-04-02T14:03:03Z 2017-04-02T14:03:03Z CONTRIBUTOR

@shoyer, changes have been made as requested. Thanks!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Marks slow, flaky, and failing tests 217660739
290571024 https://github.com/pydata/xarray/pull/1336#issuecomment-290571024 https://api.github.com/repos/pydata/xarray/issues/1336 MDEyOklzc3VlQ29tbWVudDI5MDU3MTAyNA== pwolfram 4295853 2017-03-30T23:12:15Z 2017-03-30T23:12:15Z CONTRIBUTOR

This also fixes the issue noted in https://github.com/pydata/xarray/pull/1038 where flakey tests cause travis CI failure.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Marks slow, flaky, and failing tests 217660739
290570908 https://github.com/pydata/xarray/pull/1336#issuecomment-290570908 https://api.github.com/repos/pydata/xarray/issues/1336 MDEyOklzc3VlQ29tbWVudDI5MDU3MDkwOA== pwolfram 4295853 2017-03-30T23:11:29Z 2017-03-30T23:11:29Z CONTRIBUTOR

@shoyer, as we discussed, here is a robustness-ing of the testing as needed for 0.9.2

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Marks slow, flaky, and failing tests 217660739
290255222 https://github.com/pydata/xarray/pull/1336#issuecomment-290255222 https://api.github.com/repos/pydata/xarray/issues/1336 MDEyOklzc3VlQ29tbWVudDI5MDI1NTIyMg== shoyer 1217238 2017-03-29T23:18:01Z 2017-03-29T23:18:01Z MEMBER

@pwolfram Thanks for putting this together.

"Slow" tests on Travis aren't a huge problem -- it takes at least a minute for Travis to complete even in the best case scenario, so having to wait a minute more is not so bad. It's really an issue for interactive, local development, where it's really valuable for tests to complete in less than 10 seconds.

Flaky tests, which fail sometimes, are the problem. So think we want a different category for these many file tests, maybe "Flaky". Ideally we would have an another Travis-CI job setup to run these that isn't required to always pass, like our existing jobs for testing development versions of other libraries.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Marks slow, flaky, and failing tests 217660739
290193129 https://github.com/pydata/xarray/pull/1336#issuecomment-290193129 https://api.github.com/repos/pydata/xarray/issues/1336 MDEyOklzc3VlQ29tbWVudDI5MDE5MzEyOQ== pwolfram 4295853 2017-03-29T19:05:04Z 2017-03-29T19:05:04Z CONTRIBUTOR

@shoyer, is there anything else you would like done on this before merging? 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Marks slow, flaky, and failing tests 217660739
289880785 https://github.com/pydata/xarray/pull/1336#issuecomment-289880785 https://api.github.com/repos/pydata/xarray/issues/1336 MDEyOklzc3VlQ29tbWVudDI4OTg4MDc4NQ== pwolfram 4295853 2017-03-28T19:37:12Z 2017-03-28T19:37:12Z CONTRIBUTOR

@shoyer, all tests pass and I've spot checked that this works as expected, e.g., ```python xarray/tests/test_backends.py::OpenMFDatasetManyFilesTest::test_1_autoclose_netcdf4 PASSED

xarray/tests/test_backends.py::OpenMFDatasetManyFilesTest::test_1_open_large_num_files_netcdf4 SKIPPED

xarray/tests/test_backends.py::OpenMFDatasetManyFilesTest::test_2_autoclose_scipy PASSED

xarray/tests/test_backends.py::OpenMFDatasetManyFilesTest::test_2_open_large_num_files_scipy SKIPPED

xarray/tests/test_backends.py::OpenMFDatasetManyFilesTest::test_3_autoclose_pynio PASSED

xarray/tests/test_backends.py::OpenMFDatasetManyFilesTest::test_3_open_large_num_files_pynio SKIPPED ```

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Marks slow, flaky, and failing tests 217660739
289874334 https://github.com/pydata/xarray/pull/1336#issuecomment-289874334 https://api.github.com/repos/pydata/xarray/issues/1336 MDEyOklzc3VlQ29tbWVudDI4OTg3NDMzNA== pwolfram 4295853 2017-03-28T19:12:21Z 2017-03-28T19:12:30Z CONTRIBUTOR

@shoyer et al, please feel free to mark additional tests as slow in this PR. I only marked the ones from #1198 that were too slow for this round. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Marks slow, flaky, and failing tests 217660739
289872994 https://github.com/pydata/xarray/pull/1336#issuecomment-289872994 https://api.github.com/repos/pydata/xarray/issues/1336 MDEyOklzc3VlQ29tbWVudDI4OTg3Mjk5NA== pwolfram 4295853 2017-03-28T19:07:01Z 2017-03-28T19:07:01Z CONTRIBUTOR

cc @MaximilianR 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Marks slow, flaky, and failing tests 217660739
289872510 https://github.com/pydata/xarray/pull/1336#issuecomment-289872510 https://api.github.com/repos/pydata/xarray/issues/1336 MDEyOklzc3VlQ29tbWVudDI4OTg3MjUxMA== pwolfram 4295853 2017-03-28T19:05:14Z 2017-03-28T19:05:14Z CONTRIBUTOR

@shoyer, this PR should also fix the issue with travis CI failing due to testing of too many open files. Note, when a user runs py.test locally, the slow tests will run. They can be skipped via running py.test --skip-slow.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Marks slow, flaky, and failing tests 217660739

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);