issue_comments

Table actions

3 rows where author_association = "MEMBER", issue = 206137485 and user = 1217238 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • shoyer · 3 ✖

issue 1

  • Provide more detailed copyright information · 3 ✖

author_association 1

  • MEMBER · 3 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
278703545 https://github.com/pydata/xarray/issues/1254#issuecomment-278703545 https://api.github.com/repos/pydata/xarray/issues/1254 MDEyOklzc3VlQ29tbWVudDI3ODcwMzU0NQ== shoyer 1217238 2017-02-09T16:58:40Z 2017-02-09T16:58:40Z MEMBER

Did my explanation make sense?

Yes, I agree and appreciate your feedback 👍.

I'll see what I can put together here to make things easier for downstream distributors. Since we do have a few files with mixed copyright, a NOTICE file could be appropriate.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Provide more detailed copyright information 206137485
278686390 https://github.com/pydata/xarray/issues/1254#issuecomment-278686390 https://api.github.com/repos/pydata/xarray/issues/1254 MDEyOklzc3VlQ29tbWVudDI3ODY4NjM5MA== shoyer 1217238 2017-02-09T16:03:50Z 2017-02-09T16:03:50Z MEMBER

From the page you link: "This document is a "how to" guide aimed at Apache Committers assembling LICENSE and NOTICE files for an Apache product."

Xarray is not an Apache product, so strictly speaking these guidelines do not apply.

"It does not apply to developers outside the ASF who are applying the Apache License to their work." https://www.apache.org/legal/src-headers.html

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Provide more detailed copyright information 206137485
278532896 https://github.com/pydata/xarray/issues/1254#issuecomment-278532896 https://api.github.com/repos/pydata/xarray/issues/1254 MDEyOklzc3VlQ29tbWVudDI3ODUzMjg5Ng== shoyer 1217238 2017-02-09T02:57:40Z 2017-02-09T02:57:40Z MEMBER

@ghisvail Thanks for your interest here and your help distributing xarray.

Currently, adapted/copied work is only called out in the code base itself (e.g., 1, 2, 3). But this certainly could be done less haphazardly. Probably we should include text of each license at the appropriate locations, or at least a direct reference to the fact hat it has a different license.

I'm not opposed to adding a NOTICE file, but I haven't seen it in other projects in the scientific Python space that I emulated in xarray (e.g., pandas or NumPy). NumPy doesn't call out all the licenses included it in at all (and there are quite a few), except where the source code itself appears. Maybe we're all just being careless, though :).

As for the Apache license, I see terms like If the Work includes a "NOTICE" text file... but I don't actually see where it requires writing such a file.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Provide more detailed copyright information 206137485

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);