issue_comments: 278532896

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/1254#issuecomment-278532896 https://api.github.com/repos/pydata/xarray/issues/1254 278532896 MDEyOklzc3VlQ29tbWVudDI3ODUzMjg5Ng== 1217238 2017-02-09T02:57:40Z 2017-02-09T02:57:40Z MEMBER

@ghisvail Thanks for your interest here and your help distributing xarray.

Currently, adapted/copied work is only called out in the code base itself (e.g., 1, 2, 3). But this certainly could be done less haphazardly. Probably we should include text of each license at the appropriate locations, or at least a direct reference to the fact hat it has a different license.

I'm not opposed to adding a NOTICE file, but I haven't seen it in other projects in the scientific Python space that I emulated in xarray (e.g., pandas or NumPy). NumPy doesn't call out all the licenses included it in at all (and there are quite a few), except where the source code itself appears. Maybe we're all just being careless, though :).

As for the Apache license, I see terms like If the Work includes a "NOTICE" text file... but I don't actually see where it requires writing such a file.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   206137485