issue_comments

Table actions

4 rows where author_association = "MEMBER" and issue = 200478981 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

issue 1

  • combine_first by using apply_ufunc in ops.fillna · 4 ✖

author_association 1

  • MEMBER · 4 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
274641120 https://github.com/pydata/xarray/pull/1204#issuecomment-274641120 https://api.github.com/repos/pydata/xarray/issues/1204 MDEyOklzc3VlQ29tbWVudDI3NDY0MTEyMA== shoyer 1217238 2017-01-23T22:40:23Z 2017-01-23T22:40:23Z MEMBER

Thanks for persevering on this, @chunweiyuan ! 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   combine_first by using apply_ufunc in ops.fillna 200478981
273677944 https://github.com/pydata/xarray/pull/1204#issuecomment-273677944 https://api.github.com/repos/pydata/xarray/issues/1204 MDEyOklzc3VlQ29tbWVudDI3MzY3Nzk0NA== shoyer 1217238 2017-01-19T04:15:23Z 2017-01-19T04:15:23Z MEMBER

Looks like the build is starting now.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   combine_first by using apply_ufunc in ops.fillna 200478981
273677902 https://github.com/pydata/xarray/pull/1204#issuecomment-273677902 https://api.github.com/repos/pydata/xarray/issues/1204 MDEyOklzc3VlQ29tbWVudDI3MzY3NzkwMg== shoyer 1217238 2017-01-19T04:14:59Z 2017-01-19T04:14:59Z MEMBER

Appveyor is acting up. I tried cancelling and restarting the build -- we'll see if that works. But the Travis-CI tests pass, so I wouldn't worry about.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   combine_first by using apply_ufunc in ops.fillna 200478981
272651348 https://github.com/pydata/xarray/pull/1204#issuecomment-272651348 https://api.github.com/repos/pydata/xarray/issues/1204 MDEyOklzc3VlQ29tbWVudDI3MjY1MTM0OA== shoyer 1217238 2017-01-14T20:39:18Z 2017-01-14T20:39:18Z MEMBER

I would simply copy attributes from the first argument for keep_attrs. We don't do any complex merging of attributes on any xarray methods.

On Sat, Jan 14, 2017 at 10:04 AM chunweiyuan notifications@github.com wrote:

@chunweiyuan commented on this pull request.

In xarray/core/groupby.py https://github.com/pydata/xarray/pull/1204:

@@ -382,7 +382,15 @@ def fillna(self, value):

     Dataset.fillna

     DataArray.fillna

     """

  • return self._fillna(value)

  • def _yield_applied(this, other):

I copped out and took your simple approach. It's mainly because I'm not sure how to deal with more than 2 objects in apply_ufunc when keep_attrs=True. Do I only take the first object's attributes? Maybe best left for another PR.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/pydata/xarray/pull/1204, or mute the thread https://github.com/notifications/unsubscribe-auth/ABKS1gFM7BNe3Bc60Q_02T25AOWAS5GRks5rSQ4bgaJpZM4LiOvZ .

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   combine_first by using apply_ufunc in ops.fillna 200478981

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);