issue_comments: 272651348

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/1204#issuecomment-272651348 https://api.github.com/repos/pydata/xarray/issues/1204 272651348 MDEyOklzc3VlQ29tbWVudDI3MjY1MTM0OA== 1217238 2017-01-14T20:39:18Z 2017-01-14T20:39:18Z MEMBER

I would simply copy attributes from the first argument for keep_attrs. We don't do any complex merging of attributes on any xarray methods.

On Sat, Jan 14, 2017 at 10:04 AM chunweiyuan notifications@github.com wrote:

@chunweiyuan commented on this pull request.

In xarray/core/groupby.py https://github.com/pydata/xarray/pull/1204:

@@ -382,7 +382,15 @@ def fillna(self, value):

     Dataset.fillna

     DataArray.fillna

     """

  • return self._fillna(value)

  • def _yield_applied(this, other):

I copped out and took your simple approach. It's mainly because I'm not sure how to deal with more than 2 objects in apply_ufunc when keep_attrs=True. Do I only take the first object's attributes? Maybe best left for another PR.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/pydata/xarray/pull/1204, or mute the thread https://github.com/notifications/unsubscribe-auth/ABKS1gFM7BNe3Bc60Q_02T25AOWAS5GRks5rSQ4bgaJpZM4LiOvZ .

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   200478981