issue_comments

Table actions

4 rows where author_association = "MEMBER", issue = 193294569 and user = 1217238 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • shoyer · 4 ✖

issue 1

  • Scalar coords vs. concat · 4 ✖

author_association 1

  • MEMBER · 4 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
269709113 https://github.com/pydata/xarray/issues/1151#issuecomment-269709113 https://api.github.com/repos/pydata/xarray/issues/1151 MDEyOklzc3VlQ29tbWVudDI2OTcwOTExMw== shoyer 1217238 2016-12-29T23:22:13Z 2016-12-29T23:22:13Z MEMBER

Is there any helper function to facilitate this?

Yes, indeed. _maybe_promote returns dtype and fill_value for inserting missing values, based on an original dtype. I guess it makes sense to start with calling one of the numpy utilities such as numpy.result_type for finding the common dtype to insert into _maybe_promote.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Scalar coords vs. concat 193294569
269507204 https://github.com/pydata/xarray/issues/1151#issuecomment-269507204 https://api.github.com/repos/pydata/xarray/issues/1151 MDEyOklzc3VlQ29tbWVudDI2OTUwNzIwNA== shoyer 1217238 2016-12-28T17:07:31Z 2016-12-28T17:07:31Z MEMBER

@crusaderky Ah, I understand now. I agree that this makes sense for concatenating along an existing dimension (e.g., xarray.concat([a, b], dim='x') or xarray.concat([a, c], dim='x')) if the variables do not have the dimension to be concatenated. The existing logic to handle merging coordinates with possible dropping is the merge_variables function in merge.py (if compat='minimal') -- note that none of the logic is specific to scalar coordinates.

For concatenating along a new dimension (e.g., xarray.concat([a, b], dim='z') or xarray.concat([a, c], dim='z')), I think we would want to default to a scalar coordinate of the appropriate missing value (e.g., coords={'y': np.nan}).

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Scalar coords vs. concat 193294569
269352243 https://github.com/pydata/xarray/issues/1151#issuecomment-269352243 https://api.github.com/repos/pydata/xarray/issues/1151 MDEyOklzc3VlQ29tbWVudDI2OTM1MjI0Mw== shoyer 1217238 2016-12-27T16:57:51Z 2016-12-27T16:57:51Z MEMBER

@crusaderky I don't understand the distinction between ambiguous/unambiguous coords -- can you clarify? Also, why treat scalar coordinates differently? Most xarray machinery doesn't special case arrays of a certain dimensionality.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Scalar coords vs. concat 193294569
264784694 https://github.com/pydata/xarray/issues/1151#issuecomment-264784694 https://api.github.com/repos/pydata/xarray/issues/1151 MDEyOklzc3VlQ29tbWVudDI2NDc4NDY5NA== shoyer 1217238 2016-12-05T07:27:54Z 2016-12-05T07:27:54Z MEMBER

I agree -- we really should do an outer join of variables/coordinates in concat. I think here is another GitHub issue tracking this (this has certainly been raised before).

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Scalar coords vs. concat 193294569

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);