issue_comments: 269507204

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/1151#issuecomment-269507204 https://api.github.com/repos/pydata/xarray/issues/1151 269507204 MDEyOklzc3VlQ29tbWVudDI2OTUwNzIwNA== 1217238 2016-12-28T17:07:31Z 2016-12-28T17:07:31Z MEMBER

@crusaderky Ah, I understand now. I agree that this makes sense for concatenating along an existing dimension (e.g., xarray.concat([a, b], dim='x') or xarray.concat([a, c], dim='x')) if the variables do not have the dimension to be concatenated. The existing logic to handle merging coordinates with possible dropping is the merge_variables function in merge.py (if compat='minimal') -- note that none of the logic is specific to scalar coordinates.

For concatenating along a new dimension (e.g., xarray.concat([a, b], dim='z') or xarray.concat([a, c], dim='z')), I think we would want to default to a scalar coordinate of the appropriate missing value (e.g., coords={'y': np.nan}).

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   193294569