issue_comments

Table actions

2 rows where author_association = "MEMBER", issue = 172291585 and user = 1217238 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: updated_at (date)

user 1

  • shoyer · 2 ✖

issue 1

  • align() should align chunks · 2 ✖

author_association 1

  • MEMBER · 2 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
457281032 https://github.com/pydata/xarray/issues/979#issuecomment-457281032 https://api.github.com/repos/pydata/xarray/issues/979 MDEyOklzc3VlQ29tbWVudDQ1NzI4MTAzMg== shoyer 1217238 2019-01-24T17:19:30Z 2019-01-24T17:19:30Z MEMBER

I think dask.array handles this differing chunk sizes better these days, so perhaps this is no longer necessary.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   align() should align chunks 172291585
241232491 https://github.com/pydata/xarray/issues/979#issuecomment-241232491 https://api.github.com/repos/pydata/xarray/issues/979 MDEyOklzc3VlQ29tbWVudDI0MTIzMjQ5MQ== shoyer 1217238 2016-08-21T00:55:11Z 2016-08-21T00:55:11Z MEMBER

I agree that it would make sense for xarray.align to unify chunks in dask arrays, but the documentation is actually a little out of date here: dask.array does now do some minimal automatic rechunking (see unify_chunks for details). Also, dask array functions, at least those that use elemwise, do automatically coerce NumPy arrays into dask arrays. So adding a tiny numpy array to a huge dask array does currently do the right thing.

As you can see, the automatic rechunking algorithm that dask.array currently uses is super simple: it only reconciles chunks when one array is unchunked. I'm certainly open to more sophisticated options for automatic rechunking (see https://github.com/dask/dask/issues/111), but either way I'd prefer to keep as much of this logic on the dask side as possible. Ideally, we'd simply call dask.array.unify_chunks passing in the named dimensions for each array.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   align() should align chunks 172291585

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);