home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 241232491

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/979#issuecomment-241232491 https://api.github.com/repos/pydata/xarray/issues/979 241232491 MDEyOklzc3VlQ29tbWVudDI0MTIzMjQ5MQ== 1217238 2016-08-21T00:55:11Z 2016-08-21T00:55:11Z MEMBER

I agree that it would make sense for xarray.align to unify chunks in dask arrays, but the documentation is actually a little out of date here: dask.array does now do some minimal automatic rechunking (see unify_chunks for details). Also, dask array functions, at least those that use elemwise, do automatically coerce NumPy arrays into dask arrays. So adding a tiny numpy array to a huge dask array does currently do the right thing.

As you can see, the automatic rechunking algorithm that dask.array currently uses is super simple: it only reconciles chunks when one array is unchunked. I'm certainly open to more sophisticated options for automatic rechunking (see https://github.com/dask/dask/issues/111), but either way I'd prefer to keep as much of this logic on the dask side as possible. Ideally, we'd simply call dask.array.unify_chunks passing in the named dimensions for each array.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  172291585
Powered by Datasette · Queries took 1.328ms · About: xarray-datasette