issue_comments

Table actions

6 rows where author_association = "MEMBER" and issue = 171828347 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 2

issue 1

  • Indexing with alignment and broadcasting · 6 ✖

author_association 1

  • MEMBER · 6 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
362949749 https://github.com/pydata/xarray/issues/974#issuecomment-362949749 https://api.github.com/repos/pydata/xarray/issues/974 MDEyOklzc3VlQ29tbWVudDM2Mjk0OTc0OQ== shoyer 1217238 2018-02-04T23:30:11Z 2018-02-04T23:30:11Z MEMBER

Vectorized indexing was implemented by https://github.com/pydata/xarray/pull/1473

I've opened a new issue #1887 for multi-dimensional boolean indexing.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Indexing with alignment and broadcasting 171828347
313982206 https://github.com/pydata/xarray/issues/974#issuecomment-313982206 https://api.github.com/repos/pydata/xarray/issues/974 MDEyOklzc3VlQ29tbWVudDMxMzk4MjIwNg== shoyer 1217238 2017-07-10T01:49:57Z 2017-07-10T02:01:58Z MEMBER

I opened a pull request with your branch in #1473 so I can comment/view your changes. I hope that's OK!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Indexing with alignment and broadcasting 171828347
313980675 https://github.com/pydata/xarray/issues/974#issuecomment-313980675 https://api.github.com/repos/pydata/xarray/issues/974 MDEyOklzc3VlQ29tbWVudDMxMzk4MDY3NQ== shoyer 1217238 2017-07-10T01:34:23Z 2017-07-10T01:34:23Z MEMBER

@fujiisoup My first two bullets for boolean indexing are actually new functionality, so we wouldn't need that for a first pass here. It actually would probably be better to save it for a second PR.

My third bullet on boolean indexing is basically just saying that da[key_1, ..., key_n] and ds.sel(x=key) should be handled in a consistent way with the new indexing behavior when given a boolean array. I don't think this will require any special adjustments -- it should fall out pretty immediately once you get the rest working.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Indexing with alignment and broadcasting 171828347
313977794 https://github.com/pydata/xarray/issues/974#issuecomment-313977794 https://api.github.com/repos/pydata/xarray/issues/974 MDEyOklzc3VlQ29tbWVudDMxMzk3Nzc5NA== fujiisoup 6815844 2017-07-10T01:00:35Z 2017-07-10T01:00:35Z MEMBER

@shoyer Thanks for the suggestions.

I don't think I fully understand how boolean indexing works. Could you show me some example use-cases?

I started from the vectorizing indexing by updating Variable.__getitem__ method, in my folked repo (test).

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Indexing with alignment and broadcasting 171828347
313170506 https://github.com/pydata/xarray/issues/974#issuecomment-313170506 https://api.github.com/repos/pydata/xarray/issues/974 MDEyOklzc3VlQ29tbWVudDMxMzE3MDUwNg== shoyer 1217238 2017-07-05T17:25:07Z 2017-07-05T17:25:20Z MEMBER

I haven't had the time to start working on this -- help would be very gratefully appreciated!

In rough order, I would suggest:

  1. Write a design doc for any new API. We basically have this here, but there may be a few aspects that still need to be thought through, so I would appreciate your critical review.
  2. Write the test suite for the new functionality. We could even submit this, with the tests marked as xfail.
  3. Implement the core functionality and get the new tests to pass. This is the fun part :).
  4. Get the existing test suite to pass. This will likely be the most painful part, because there will be a number of completely unrelated test failures. I can definitely help when we get to this stage.
 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Indexing with alignment and broadcasting 171828347
313064813 https://github.com/pydata/xarray/issues/974#issuecomment-313064813 https://api.github.com/repos/pydata/xarray/issues/974 MDEyOklzc3VlQ29tbWVudDMxMzA2NDgxMw== fujiisoup 6815844 2017-07-05T10:26:54Z 2017-07-05T10:27:19Z MEMBER

What is the current status of these proposed major changes? Is there any starting basis for them?

I have recently some free time.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Indexing with alignment and broadcasting 171828347

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);