issue_comments

Table actions

8 rows where author_association = "MEMBER" and issue = 1685422501 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 2

issue 1

  • Fix as_compatible_data for read-only np.ma.MaskedArray · 8 ✖

author_association 1

  • MEMBER · 8 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1551638978 https://github.com/pydata/xarray/pull/7788#issuecomment-1551638978 https://api.github.com/repos/pydata/xarray/issues/7788 IC_kwDOAMm_X85cfCHC dcherian 2448579 2023-05-17T15:45:41Z 2023-05-17T15:45:41Z MEMBER

Thanks @maxhollmann I pushed a test for #2377.

I see this is your first contribution to Xarray. Welcome! #1792 would be a nice contribution if you're looking for more to do ;)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix as_compatible_data for read-only np.ma.MaskedArray 1685422501
1550187275 https://github.com/pydata/xarray/pull/7788#issuecomment-1550187275 https://api.github.com/repos/pydata/xarray/issues/7788 IC_kwDOAMm_X85cZfsL dcherian 2448579 2023-05-16T18:47:27Z 2023-05-16T18:47:27Z MEMBER

Thanks @maxhollmann can you add a note to whats-new.rst please?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix as_compatible_data for read-only np.ma.MaskedArray 1685422501
1545939343 https://github.com/pydata/xarray/pull/7788#issuecomment-1545939343 https://api.github.com/repos/pydata/xarray/issues/7788 IC_kwDOAMm_X85cJSmP dcherian 2448579 2023-05-12T15:39:24Z 2023-05-12T15:39:24Z MEMBER

I defer to @shoyer, the solution with where_method seems good to me.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix as_compatible_data for read-only np.ma.MaskedArray 1685422501
1545446155 https://github.com/pydata/xarray/pull/7788#issuecomment-1545446155 https://api.github.com/repos/pydata/xarray/issues/7788 IC_kwDOAMm_X85cHaML kmuehlbauer 5821660 2023-05-12T09:23:13Z 2023-05-12T09:23:13Z MEMBER

@maxhollmann I'm sorry, I'm still finding my way into Xarray. I've taken a closer look at #2377, especially https://github.com/pydata/xarray/issues/2377#issuecomment-415074188.

There @shoyer suggested to just use:

python data = duck_array_ops.where_method(data, ~mask, fill_value)

instead of python data[mask] = fill_value

I've checked and it works nicely with your test. That way we would get away without the flags test and the special handling will take place in duck_array_ops. Would be great if someone can double check.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix as_compatible_data for read-only np.ma.MaskedArray 1685422501
1545337724 https://github.com/pydata/xarray/pull/7788#issuecomment-1545337724 https://api.github.com/repos/pydata/xarray/issues/7788 IC_kwDOAMm_X85cG_t8 kmuehlbauer 5821660 2023-05-12T07:59:19Z 2023-05-12T07:59:19Z MEMBER

@maxhollmann We might get at least some more views on this. There have been discussions on handling masked arrays and we should make sure this is exactly the solution we want to have.

@dcherian This changes as_compatible_data. Could you please have another look here? I'm a bit unclear about the implications.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix as_compatible_data for read-only np.ma.MaskedArray 1685422501
1524805132 https://github.com/pydata/xarray/pull/7788#issuecomment-1524805132 https://api.github.com/repos/pydata/xarray/issues/7788 IC_kwDOAMm_X85a4q4M kmuehlbauer 5821660 2023-04-27T06:13:23Z 2023-04-27T07:19:47Z MEMBER

@maxhollmann I've checked and memory served well, the following issue might be related: #2377. It looks like your use-case is at least connected to @gerritholl's. It would be great if you could add your original use case (as MCVE, if possible) to get more details.

A special case (masked integer arrays) is discussed in #3955. As this might give additional information, it might not exactly fit your problem.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix as_compatible_data for read-only np.ma.MaskedArray 1685422501
1523829332 https://github.com/pydata/xarray/pull/7788#issuecomment-1523829332 https://api.github.com/repos/pydata/xarray/issues/7788 IC_kwDOAMm_X85a08pU kmuehlbauer 5821660 2023-04-26T17:55:13Z 2023-04-26T17:55:13Z MEMBER

@maxhollmann I'll have a look into this, I think I've seen something like this some time ago.

Maybe you can add the tests to the PR or as comment? This might get more attention and will really help to debug. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix as_compatible_data for read-only np.ma.MaskedArray 1685422501
1523786065 https://github.com/pydata/xarray/pull/7788#issuecomment-1523786065 https://api.github.com/repos/pydata/xarray/issues/7788 IC_kwDOAMm_X85a0yFR kmuehlbauer 5821660 2023-04-26T17:18:44Z 2023-04-26T17:18:44Z MEMBER

I've marked this by accident, sorry @maxhollmann. Let us know when you feel this is ready 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix as_compatible_data for read-only np.ma.MaskedArray 1685422501

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);