issue_comments

Table actions

2 rows where author_association = "MEMBER", issue = 160505403 and user = 6815844 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • fujiisoup · 2 ✖

issue 1

  • Iterating over a Dataset iterates only over its data_vars · 2 ✖

author_association 1

  • MEMBER · 2 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
391964427 https://github.com/pydata/xarray/issues/884#issuecomment-391964427 https://api.github.com/repos/pydata/xarray/issues/884 MDEyOklzc3VlQ29tbWVudDM5MTk2NDQyNw== fujiisoup 6815844 2018-05-25T07:17:33Z 2018-05-25T07:17:33Z MEMBER

So, the behavior of dict(dataset) will change if we changed the behavior of __iter__. Can we issue a warning if dict(dataset) is called (or is it impossible)?

In #2162, you changed python for k, v in dataset.items(): to python dataset = OrderedDict(dataset) for k, v in dataset.items(): to avoid the warning, but I am afraid it will cause the unexpected behavior when we stop supporting iteration over coordinates.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Iterating over a Dataset iterates only over its data_vars 160505403
391943527 https://github.com/pydata/xarray/issues/884#issuecomment-391943527 https://api.github.com/repos/pydata/xarray/issues/884 MDEyOklzc3VlQ29tbWVudDM5MTk0MzUyNw== fujiisoup 6815844 2018-05-25T05:15:41Z 2018-05-25T05:15:41Z MEMBER

Do we need to change the behavior of dict(dataset) so that dict(dataset).keys() and dataset.keys() become consistent?

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Iterating over a Dataset iterates only over its data_vars 160505403

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);