issue_comments: 391964427

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/884#issuecomment-391964427 https://api.github.com/repos/pydata/xarray/issues/884 391964427 MDEyOklzc3VlQ29tbWVudDM5MTk2NDQyNw== 6815844 2018-05-25T07:17:33Z 2018-05-25T07:17:33Z MEMBER

So, the behavior of dict(dataset) will change if we changed the behavior of __iter__. Can we issue a warning if dict(dataset) is called (or is it impossible)?

In #2162, you changed python for k, v in dataset.items(): to python dataset = OrderedDict(dataset) for k, v in dataset.items(): to avoid the warning, but I am afraid it will cause the unexpected behavior when we stop supporting iteration over coordinates.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   160505403