home / github

Menu
  • GraphQL API
  • Search all tables

issue_comments

Table actions
  • GraphQL API for issue_comments

7 rows where author_association = "MEMBER" and issue = 160009256 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 3

  • mathause 3
  • shoyer 2
  • fmaussion 2

issue 1

  • add geocolormesh · 7 ✖

author_association 1

  • MEMBER · 7 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
226502318 https://github.com/pydata/xarray/pull/882#issuecomment-226502318 https://api.github.com/repos/pydata/xarray/issues/882 MDEyOklzc3VlQ29tbWVudDIyNjUwMjMxOA== mathause 10194086 2016-06-16T14:29:36Z 2016-06-16T14:29:36Z MEMBER

What may be possible: extend @_plot2d with a projection=None and a transform=None keyword (and the handling thereof)*. In geoplot we import @_plot2d set the defaults to projection=ccrs.PlateCaree() and transform=ccrs.PlateCaree(), possibly intercept coastlines from kwargs. I don't know if it is possible to update the defaults without explicitly re-writing the call signature of the function (which may change (but this could possibly be tested)).

* This may conflict with the current ax = plt.gca().

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  add geocolormesh 160009256
226480439 https://github.com/pydata/xarray/pull/882#issuecomment-226480439 https://api.github.com/repos/pydata/xarray/issues/882 MDEyOklzc3VlQ29tbWVudDIyNjQ4MDQzOQ== fmaussion 10050469 2016-06-16T13:11:29Z 2016-06-16T13:11:29Z MEMBER

We would need to think hard about how to extend the current implementation without needing to duplicate it.

Do you think it would be enough to expose the @_plot2d decorator?

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  add geocolormesh 160009256
226411408 https://github.com/pydata/xarray/pull/882#issuecomment-226411408 https://api.github.com/repos/pydata/xarray/issues/882 MDEyOklzc3VlQ29tbWVudDIyNjQxMTQwOA== mathause 10194086 2016-06-16T07:42:13Z 2016-06-16T07:42:13Z MEMBER

Yes is is possible to say subplot_kws=dict(projection=ccrs.PlateCaree(). For a single plot it is not possible to specify the projection (as ax=plt.gca()) in the current implementation. Thus one has to create and pass a geoaxes explicitly.

I like the idea of doing data.geoplot.pcolormesh() - We could keep the standard name of the plotting function without the need to make up our own. - It is possibly easier to extend it to contour and contourf. - We can possibly offer more control over specific cartopy features (although adding coasts is possibly the one thing that we will be able to agree on).

Some questions: - Would it also offer data.geoplot.line ect.? There is no point but this would be consistent might be asked for. - We would need to think hard about how to extend the current implementation without needing to duplicate it.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  add geocolormesh 160009256
226252313 https://github.com/pydata/xarray/pull/882#issuecomment-226252313 https://api.github.com/repos/pydata/xarray/issues/882 MDEyOklzc3VlQ29tbWVudDIyNjI1MjMxMw== shoyer 1217238 2016-06-15T17:03:07Z 2016-06-15T17:03:07Z MEMBER

I'm pretty sure it's possible to add cartopy axes to a FacetGrid using the subplot_kwds argument already. Unfortunately, I don't have any examples handy since I wrote that code at my last job.

What this code does is add the projection=ccrs.PlateCarree() automatically, along with a few other geo specific niceties. I made that suggestion for cartopy itself (https://github.com/SciTools/cartopy/issues/645) but it hasn't been acted on yet.

I agree that this is a good fit for xarray because the plotting API is difficult to extend externally. One nice way to present this to users could be to make a geoplot accessor that works like the current plot accessor but adds these geo specific options. Then you could write, e.g., data.geoplot.pcolormesh().

{
    "total_count": 2,
    "+1": 2,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  add geocolormesh 160009256
226132209 https://github.com/pydata/xarray/pull/882#issuecomment-226132209 https://api.github.com/repos/pydata/xarray/issues/882 MDEyOklzc3VlQ29tbWVudDIyNjEzMjIwOQ== fmaussion 10050469 2016-06-15T09:13:50Z 2016-06-15T09:13:50Z MEMBER

I also agree that this is a not to intrusive and useful "geo-specific" addition. Without looking at the implementation, I also wonder if it would be possible to add the same functionality to the existing framework without adding a specific function? The background is that there are other ways than pcolormesh to plot on a map (see also https://github.com/pydata/xarray/issues/657)

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  add geocolormesh 160009256
225772187 https://github.com/pydata/xarray/pull/882#issuecomment-225772187 https://api.github.com/repos/pydata/xarray/issues/882 MDEyOklzc3VlQ29tbWVudDIyNTc3MjE4Nw== shoyer 1217238 2016-06-14T03:42:13Z 2016-06-14T03:42:13Z MEMBER

I was trying to avoid getting too much geo-specific functionality in xarray, but this does nicely extend the existing plotting methods, so I think this is a reasonable addition. Anyone else have opinions on this one?

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  add geocolormesh 160009256
225663415 https://github.com/pydata/xarray/pull/882#issuecomment-225663415 https://api.github.com/repos/pydata/xarray/issues/882 MDEyOklzc3VlQ29tbWVudDIyNTY2MzQxNQ== mathause 10194086 2016-06-13T18:14:04Z 2016-06-13T18:14:04Z MEMBER

These are the plots from above.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  add geocolormesh 160009256

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options:

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);
Powered by Datasette · Queries took 12.665ms · About: xarray-datasette