issue_comments

Table actions

2 rows where author_association = "MEMBER" and issue = 1562840229 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

issue 1

  • Remove Dask single-threaded setting in tests · 2 ✖

author_association 1

  • MEMBER · 2 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1410893053 https://github.com/pydata/xarray/pull/7489#issuecomment-1410893053 https://api.github.com/repos/pydata/xarray/issues/7489 IC_kwDOAMm_X85UGIT9 dcherian 2448579 2023-01-31T18:45:38Z 2023-01-31T18:45:54Z MEMBER

Yup, after thinking about it for a while, this seems like an edge case that's not common in user code.

Thanks @jrbourbeau !

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Remove Dask single-threaded setting in tests 1562840229
1409077985 https://github.com/pydata/xarray/pull/7489#issuecomment-1409077985 https://api.github.com/repos/pydata/xarray/issues/7489 IC_kwDOAMm_X85T_NLh dcherian 2448579 2023-01-30T18:03:36Z 2023-01-30T18:03:36Z MEMBER

Oh hmm that was trivial.

Is this a regression though?

The test has a distributed.Client created in a context manager. https://github.com/pydata/xarray/blob/d385e2063a6b5919e1fe9dd3e27a24bc7117137e/xarray/tests/test_distributed.py#L104-L116

but it seems like dask.base.get_scheduler isn't returning a distributed.Client any more (this is called somewhere in the to_netcdf call chain) https://github.com/pydata/xarray/blob/d385e2063a6b5919e1fe9dd3e27a24bc7117137e/xarray/backends/locks.py#L71-L106

actual_get is now get_sync whereas it used to be a the get for a distributed.Client.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Remove Dask single-threaded setting in tests 1562840229

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);