issue_comments: 1409077985

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/7489#issuecomment-1409077985 https://api.github.com/repos/pydata/xarray/issues/7489 1409077985 IC_kwDOAMm_X85T_NLh 2448579 2023-01-30T18:03:36Z 2023-01-30T18:03:36Z MEMBER

Oh hmm that was trivial.

Is this a regression though?

The test has a distributed.Client created in a context manager. https://github.com/pydata/xarray/blob/d385e2063a6b5919e1fe9dd3e27a24bc7117137e/xarray/tests/test_distributed.py#L104-L116

but it seems like dask.base.get_scheduler isn't returning a distributed.Client any more (this is called somewhere in the to_netcdf call chain) https://github.com/pydata/xarray/blob/d385e2063a6b5919e1fe9dd3e27a24bc7117137e/xarray/backends/locks.py#L71-L106

actual_get is now get_sync whereas it used to be a the get for a distributed.Client.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   1562840229