issue_comments
5 rows where author_association = "MEMBER" and issue = 151483622 sorted by updated_at descending
This data as json, CSV (advanced)
Suggested facets: created_at (date), updated_at (date)
issue 1
- Fixed a bug that showed when trying to establish equivalence of two a… · 5 ✖
id | html_url | issue_url | node_id | user | created_at | updated_at ▲ | author_association | body | reactions | performed_via_github_app | issue |
---|---|---|---|---|---|---|---|---|---|---|---|
228419690 | https://github.com/pydata/xarray/pull/837#issuecomment-228419690 | https://api.github.com/repos/pydata/xarray/issues/837 | MDEyOklzc3VlQ29tbWVudDIyODQxOTY5MA== | shoyer 1217238 | 2016-06-24T18:13:36Z | 2016-06-24T18:13:36Z | MEMBER | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Fixed a bug that showed when trying to establish equivalence of two a… 151483622 | ||
222873697 | https://github.com/pydata/xarray/pull/837#issuecomment-222873697 | https://api.github.com/repos/pydata/xarray/issues/837 | MDEyOklzc3VlQ29tbWVudDIyMjg3MzY5Nw== | shoyer 1217238 | 2016-06-01T02:07:42Z | 2016-06-01T02:07:42Z | MEMBER | This looks good to me. The test could probably still be made more succinct but this covers the essentials. I like that it provides an integration test for using rec arrays. @jhamman any more comments before I merge? |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Fixed a bug that showed when trying to establish equivalence of two a… 151483622 | |
218359954 | https://github.com/pydata/xarray/pull/837#issuecomment-218359954 | https://api.github.com/repos/pydata/xarray/issues/837 | MDEyOklzc3VlQ29tbWVudDIxODM1OTk1NA== | jhamman 2443309 | 2016-05-11T04:38:51Z | 2016-05-11T04:38:51Z | MEMBER | @maciekswat - this is almost there. @shoyer and I each have comments remaining that should be addressed and then we need a bug fix entry in "what's new". Thanks! |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Fixed a bug that showed when trying to establish equivalence of two a… 151483622 | |
216310274 | https://github.com/pydata/xarray/pull/837#issuecomment-216310274 | https://api.github.com/repos/pydata/xarray/issues/837 | MDEyOklzc3VlQ29tbWVudDIxNjMxMDI3NA== | shoyer 1217238 | 2016-05-02T17:56:03Z | 2016-05-02T17:56:03Z | MEMBER | @maciekswat awesome -- thanks! can you please run your code through a PEP8 checker like pep8 or pyflakes? some of your spacing is off. also, please add a note to "What's new" giving yourself credit for the bug fix :). |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Fixed a bug that showed when trying to establish equivalence of two a… 151483622 | |
215291343 | https://github.com/pydata/xarray/pull/837#issuecomment-215291343 | https://api.github.com/repos/pydata/xarray/issues/837 | MDEyOklzc3VlQ29tbWVudDIxNTI5MTM0Mw== | shoyer 1217238 | 2016-04-28T02:36:01Z | 2016-04-28T02:36:01Z | MEMBER | Thanks for looking into this! Just to summarize, the issue is that ```
The problem with your current patch is that it will actually compare all array elements twice. Because checks for equality are done quite often in xarray, this will have prohibitive performance cost. So, we'll either need to check for structured dtypes, or catch Also, we need tests, to verify that the bug is fixed. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Fixed a bug that showed when trying to establish equivalence of two a… 151483622 |
Advanced export
JSON shape: default, array, newline-delimited, object
CREATE TABLE [issue_comments] ( [html_url] TEXT, [issue_url] TEXT, [id] INTEGER PRIMARY KEY, [node_id] TEXT, [user] INTEGER REFERENCES [users]([id]), [created_at] TEXT, [updated_at] TEXT, [author_association] TEXT, [body] TEXT, [reactions] TEXT, [performed_via_github_app] TEXT, [issue] INTEGER REFERENCES [issues]([id]) ); CREATE INDEX [idx_issue_comments_issue] ON [issue_comments] ([issue]); CREATE INDEX [idx_issue_comments_user] ON [issue_comments] ([user]);
user 2