issue_comments: 215291343

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/837#issuecomment-215291343 https://api.github.com/repos/pydata/xarray/issues/837 215291343 MDEyOklzc3VlQ29tbWVudDIxNTI5MTM0Mw== 1217238 2016-04-28T02:36:01Z 2016-04-28T02:36:01Z MEMBER

Thanks for looking into this!

Just to summarize, the issue is that isnull doesn't work on structured dtypes:

```

pd.isnull(p_data) TypeError: Not implemented for this type ```

The problem with your current patch is that it will actually compare all array elements twice. Because checks for equality are done quite often in xarray, this will have prohibitive performance cost.

So, we'll either need to check for structured dtypes, or catch TypeError exceptions and try doing the comparison without checking for nulls.

Also, we need tests, to verify that the bug is fixed.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   151483622