issue_comments
21 rows where author_association = "MEMBER" and issue = 1508009922 sorted by updated_at descending
This data as json, CSV (advanced)
Suggested facets: reactions, created_at (date), updated_at (date)
issue 1
- Fill missing data_vars during concat by reindexing · 21 ✖
id | html_url | issue_url | node_id | user | created_at | updated_at ▲ | author_association | body | reactions | performed_via_github_app | issue |
---|---|---|---|---|---|---|---|---|---|---|---|
1397995523 | https://github.com/pydata/xarray/pull/7400#issuecomment-1397995523 | https://api.github.com/repos/pydata/xarray/issues/7400 | IC_kwDOAMm_X85TU7gD | kmuehlbauer 5821660 | 2023-01-20T07:05:43Z | 2023-01-20T07:05:43Z | MEMBER | @dcherian There slipped an old item from whats-new.rst back into. I've removed it. Should be OK now. Great to see this functionality coming to next xarray version. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Fill missing data_vars during concat by reindexing 1508009922 | |
1397034476 | https://github.com/pydata/xarray/pull/7400#issuecomment-1397034476 | https://api.github.com/repos/pydata/xarray/issues/7400 | IC_kwDOAMm_X85TRQ3s | kmuehlbauer 5821660 | 2023-01-19T14:06:57Z | 2023-01-19T14:06:57Z | MEMBER | @dcherian rebased on latest main and fixed whats-new.rst. Should be good for another review. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Fill missing data_vars during concat by reindexing 1508009922 | |
1385597317 | https://github.com/pydata/xarray/pull/7400#issuecomment-1385597317 | https://api.github.com/repos/pydata/xarray/issues/7400 | IC_kwDOAMm_X85SlomF | dcherian 2448579 | 2023-01-17T15:24:45Z | 2023-01-17T15:24:45Z | MEMBER | I pushed a commit. Turns out |
{ "total_count": 1, "+1": 0, "-1": 0, "laugh": 0, "hooray": 1, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Fill missing data_vars during concat by reindexing 1508009922 | |
1385060058 | https://github.com/pydata/xarray/pull/7400#issuecomment-1385060058 | https://api.github.com/repos/pydata/xarray/issues/7400 | IC_kwDOAMm_X85Sjlba | kmuehlbauer 5821660 | 2023-01-17T09:07:43Z | 2023-01-17T09:07:43Z | MEMBER | @dcherian @keewis The resulting variables are now in order of appearance as suggested. This is backwards compatible and deterministic. Needs decision:
- convert |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Fill missing data_vars during concat by reindexing 1508009922 | |
1383186654 | https://github.com/pydata/xarray/pull/7400#issuecomment-1383186654 | https://api.github.com/repos/pydata/xarray/issues/7400 | IC_kwDOAMm_X85SccDe | kmuehlbauer 5821660 | 2023-01-15T15:58:20Z | 2023-01-15T15:58:20Z | MEMBER | Thanks Deepak, I've already have some answers on your review. Will check the other things the next days. |
{ "total_count": 1, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 1, "rocket": 0, "eyes": 0 } |
Fill missing data_vars during concat by reindexing 1508009922 | |
1382657234 | https://github.com/pydata/xarray/pull/7400#issuecomment-1382657234 | https://api.github.com/repos/pydata/xarray/issues/7400 | IC_kwDOAMm_X85SaazS | dcherian 2448579 | 2023-01-14T04:21:30Z | 2023-01-14T04:21:30Z | MEMBER | Thanks Kai. I can take a look early next week. Sorry for the delay here, I just got back from a long vacation |
{ "total_count": 1, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 1, "rocket": 0, "eyes": 0 } |
Fill missing data_vars during concat by reindexing 1508009922 | |
1381379922 | https://github.com/pydata/xarray/pull/7400#issuecomment-1381379922 | https://api.github.com/repos/pydata/xarray/issues/7400 | IC_kwDOAMm_X85SVi9S | kmuehlbauer 5821660 | 2023-01-13T06:38:46Z | 2023-01-13T06:38:46Z | MEMBER | Gentle ping @shoyer, as original issue author, and @dcherian for feedback. Any suggestions for improvement much appreciated. Thanks! @Illviljan I'd prefer to handle benchmark in subsequent PR. Thanks for the links! |
{ "total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Fill missing data_vars during concat by reindexing 1508009922 | |
1378321206 | https://github.com/pydata/xarray/pull/7400#issuecomment-1378321206 | https://api.github.com/repos/pydata/xarray/issues/7400 | IC_kwDOAMm_X85SJ4M2 | kmuehlbauer 5821660 | 2023-01-11T07:07:26Z | 2023-01-11T07:07:26Z | MEMBER | Thanks for bringing benchmarks back to life here @Illviljan. It's good to see that the changes from this PR do not affect the performance AFAICT. It might make sense to add a benchmark for concatenation a large number of datasets with a large number of variables (with and without missing variables in some datasets) to check for performance of those special cases. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Fill missing data_vars during concat by reindexing 1508009922 | |
1377398820 | https://github.com/pydata/xarray/pull/7400#issuecomment-1377398820 | https://api.github.com/repos/pydata/xarray/issues/7400 | IC_kwDOAMm_X85SGXAk | kmuehlbauer 5821660 | 2023-01-10T14:54:48Z | 2023-01-10T14:54:48Z | MEMBER | Finally, this is as far I could get with it. I'll leave it as is now. Looking forward for reviews and suggestions. Thanks @Illviljan for the great support! |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Fill missing data_vars during concat by reindexing 1508009922 | |
1377371093 | https://github.com/pydata/xarray/pull/7400#issuecomment-1377371093 | https://api.github.com/repos/pydata/xarray/issues/7400 | IC_kwDOAMm_X85SGQPV | kmuehlbauer 5821660 | 2023-01-10T14:33:41Z | 2023-01-10T14:33:41Z | MEMBER | I was hoping to gain something by merging the variable order code with The current behaviour, and the best I've come up so far in terms of performance:
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Fill missing data_vars during concat by reindexing 1508009922 | |
1375547139 | https://github.com/pydata/xarray/pull/7400#issuecomment-1375547139 | https://api.github.com/repos/pydata/xarray/issues/7400 | IC_kwDOAMm_X85R_S8D | kmuehlbauer 5821660 | 2023-01-09T12:21:03Z | 2023-01-09T12:21:03Z | MEMBER | @scottcha I think I've managed to get along with your tests. It looks like everything is running now. One thing which is still unresolved:
@Illviljan @dcherian This is ready for another round of review. Thanks for considering. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Fill missing data_vars during concat by reindexing 1508009922 | |
1374874926 | https://github.com/pydata/xarray/pull/7400#issuecomment-1374874926 | https://api.github.com/repos/pydata/xarray/issues/7400 | IC_kwDOAMm_X85R8u0u | kmuehlbauer 5821660 | 2023-01-08T16:28:06Z | 2023-01-08T16:28:06Z | MEMBER | @Illviljan OK, I'm stuck now. I can't make anything out of the remaining mypy errors. Would be great if you could have another look here, thanks! |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Fill missing data_vars during concat by reindexing 1508009922 | |
1374863234 | https://github.com/pydata/xarray/pull/7400#issuecomment-1374863234 | https://api.github.com/repos/pydata/xarray/issues/7400 | IC_kwDOAMm_X85R8r-C | kmuehlbauer 5821660 | 2023-01-08T15:32:36Z | 2023-01-08T15:32:36Z | MEMBER | @scottcha I've tried to cherry-pick, but ended up copy/pasting and adding your authorship to the commit. I think the final problem is the order in:
These tests are flaky. Sometimes the order is correct and sometimes not. Can't immediately see the root cause here. @Illviljan I'll try to add typing to these additional tests. Should be good for learning that. |
{ "total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Fill missing data_vars during concat by reindexing 1508009922 | |
1374858441 | https://github.com/pydata/xarray/pull/7400#issuecomment-1374858441 | https://api.github.com/repos/pydata/xarray/issues/7400 | IC_kwDOAMm_X85R8qzJ | kmuehlbauer 5821660 | 2023-01-08T15:09:45Z | 2023-01-08T15:09:45Z | MEMBER | @scottcha I've found a glitch in the code due to your tests. Already pushed the changes here. I'm going to cherry pick your tests here next. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Fill missing data_vars during concat by reindexing 1508009922 | |
1374772884 | https://github.com/pydata/xarray/pull/7400#issuecomment-1374772884 | https://api.github.com/repos/pydata/xarray/issues/7400 | IC_kwDOAMm_X85R8V6U | kmuehlbauer 5821660 | 2023-01-08T09:20:25Z | 2023-01-08T09:20:25Z | MEMBER |
Thanks @Illviljan, your suggestions and help is much appreciated. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Fill missing data_vars during concat by reindexing 1508009922 | |
1374750159 | https://github.com/pydata/xarray/pull/7400#issuecomment-1374750159 | https://api.github.com/repos/pydata/xarray/issues/7400 | IC_kwDOAMm_X85R8QXP | kmuehlbauer 5821660 | 2023-01-08T08:03:20Z | 2023-01-08T08:03:20Z | MEMBER | Thanks @scottcha for taking the time to testing things. I'll have a look at your tests in more detail now. I've concentrated on my use case in the first place and hoped to get away with it :grinning:. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Fill missing data_vars during concat by reindexing 1508009922 | |
1371916247 | https://github.com/pydata/xarray/pull/7400#issuecomment-1371916247 | https://api.github.com/repos/pydata/xarray/issues/7400 | IC_kwDOAMm_X85RxcfX | kmuehlbauer 5821660 | 2023-01-05T08:28:36Z | 2023-01-05T08:28:36Z | MEMBER | This is ready for a first round of review. Thanks! |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Fill missing data_vars during concat by reindexing 1508009922 | |
1370961625 | https://github.com/pydata/xarray/pull/7400#issuecomment-1370961625 | https://api.github.com/repos/pydata/xarray/issues/7400 | IC_kwDOAMm_X85RtzbZ | kmuehlbauer 5821660 | 2023-01-04T13:58:15Z | 2023-01-04T13:58:15Z | MEMBER | OK, green light's now also on mypy. Looks like the approach would work in general. Trying to add some tests now. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Fill missing data_vars during concat by reindexing 1508009922 | |
1370866073 | https://github.com/pydata/xarray/pull/7400#issuecomment-1370866073 | https://api.github.com/repos/pydata/xarray/issues/7400 | IC_kwDOAMm_X85RtcGZ | Illviljan 14371165 | 2023-01-04T12:25:45Z | 2023-01-04T12:25:45Z | MEMBER | Benchmark is a numba issue, probably #7306. Mypy is real, cannot getitem a object. Try out using isinstance instead of the try/except to narrow the typing. |
{ "total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Fill missing data_vars during concat by reindexing 1508009922 | |
1370816761 | https://github.com/pydata/xarray/pull/7400#issuecomment-1370816761 | https://api.github.com/repos/pydata/xarray/issues/7400 | IC_kwDOAMm_X85RtQD5 | kmuehlbauer 5821660 | 2023-01-04T11:33:49Z | 2023-01-04T11:33:49Z | MEMBER | Thanks @Illviljan for activating the benchmark runs. Are those errors related to the changes? I'm not up to date with mypy, are these errors induced by changes here? |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Fill missing data_vars during concat by reindexing 1508009922 | |
1362932865 | https://github.com/pydata/xarray/pull/7400#issuecomment-1362932865 | https://api.github.com/repos/pydata/xarray/issues/7400 | IC_kwDOAMm_X85RPLSB | kmuehlbauer 5821660 | 2022-12-22T14:53:04Z | 2022-12-22T14:53:04Z | MEMBER | There are no tests added currently. I'm just wondering, if that approach would work in general. The current assumptions here:
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Fill missing data_vars during concat by reindexing 1508009922 |
Advanced export
JSON shape: default, array, newline-delimited, object
CREATE TABLE [issue_comments] ( [html_url] TEXT, [issue_url] TEXT, [id] INTEGER PRIMARY KEY, [node_id] TEXT, [user] INTEGER REFERENCES [users]([id]), [created_at] TEXT, [updated_at] TEXT, [author_association] TEXT, [body] TEXT, [reactions] TEXT, [performed_via_github_app] TEXT, [issue] INTEGER REFERENCES [issues]([id]) ); CREATE INDEX [idx_issue_comments_issue] ON [issue_comments] ([issue]); CREATE INDEX [idx_issue_comments_user] ON [issue_comments] ([user]);
user 3