issue_comments: 1377371093

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/7400#issuecomment-1377371093 https://api.github.com/repos/pydata/xarray/issues/7400 1377371093 IC_kwDOAMm_X85SGQPV 5821660 2023-01-10T14:33:41Z 2023-01-10T14:33:41Z MEMBER

I was hoping to gain something by merging the variable order code with _parse_datasets, to only have to traverse the datasets once.

The current behaviour, and the best I've come up so far in terms of performance:

  1. count number of variables while iterating datasets (_parse_datasets)
  2. check if first dataset contains all wanted variables 2a. if that's the case, take the order from first dataset
  3. check if the dataset with max count variables contains all wanted variables 3a. if that's the case, take the order from that dataset
  4. if not 2a or 3a, take order from first dataset and append missing variables to the end
 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   1508009922