issue_comments

Table actions

4 rows where author_association = "MEMBER" and issue = 148903579 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 2

issue 1

  • keep_attrs for Dataset.resample and DataArray.resample · 4 ✖

author_association 1

  • MEMBER · 4 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
211996971 https://github.com/pydata/xarray/pull/829#issuecomment-211996971 https://api.github.com/repos/pydata/xarray/issues/829 MDEyOklzc3VlQ29tbWVudDIxMTk5Njk3MQ== shoyer 1217238 2016-04-19T16:06:03Z 2016-04-19T16:06:03Z MEMBER

@mcgibbon thanks.

I agree that there is a careful balance when writing test methods between maintainability and readability.

I do think fixtures that can be helpful, but we definitely do over-use them right now with our giant test cases -- those should really be cleaned up and split up. I just haven't had the energy to get around to that.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   keep_attrs for Dataset.resample and DataArray.resample 148903579
211506678 https://github.com/pydata/xarray/pull/829#issuecomment-211506678 https://api.github.com/repos/pydata/xarray/issues/829 MDEyOklzc3VlQ29tbWVudDIxMTUwNjY3OA== max-sixty 5635139 2016-04-18T18:08:09Z 2016-04-18T18:08:09Z MEMBER

@mcgibbon That makes sense to me

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   keep_attrs for Dataset.resample and DataArray.resample 148903579
210955296 https://github.com/pydata/xarray/pull/829#issuecomment-210955296 https://api.github.com/repos/pydata/xarray/issues/829 MDEyOklzc3VlQ29tbWVudDIxMDk1NTI5Ng== max-sixty 5635139 2016-04-17T04:34:52Z 2016-04-17T04:34:52Z MEMBER

I know I'm late to the party here. Are there many cases where keep_attrs would be expected to be False? I would have thought that it's generally expected that attrs would stick around when doing operations, either as a default or without an option to drop them. (Of course, it's easy to drop them if a user explicitly sets them to {} in a separate operation)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   keep_attrs for Dataset.resample and DataArray.resample 148903579
210939902 https://github.com/pydata/xarray/pull/829#issuecomment-210939902 https://api.github.com/repos/pydata/xarray/issues/829 MDEyOklzc3VlQ29tbWVudDIxMDkzOTkwMg== shoyer 1217238 2016-04-17T02:20:46Z 2016-04-17T02:20:46Z MEMBER

Thanks for diving into this!

I think you can write the tests a little bit more succinctly, but otherwise this looks good. Also, please add a note to the "What's New" giving yourself credit. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   keep_attrs for Dataset.resample and DataArray.resample 148903579

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);