home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 210939902

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/829#issuecomment-210939902 https://api.github.com/repos/pydata/xarray/issues/829 210939902 MDEyOklzc3VlQ29tbWVudDIxMDkzOTkwMg== 1217238 2016-04-17T02:20:46Z 2016-04-17T02:20:46Z MEMBER

Thanks for diving into this!

I think you can write the tests a little bit more succinctly, but otherwise this looks good. Also, please add a note to the "What's New" giving yourself credit.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  148903579
Powered by Datasette · Queries took 0.803ms · About: xarray-datasette