issue_comments

Table actions

2 rows where author_association = "MEMBER", issue = 1477931237 and user = 6628425 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date)

user 1

  • spencerkclark · 2 ✖

issue 1

  • COMPAT: Adjust CFTimeIndex.get_loc for pandas 2.0 deprecation enforcement · 2 ✖

author_association 1

  • MEMBER · 2 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1347554206 https://github.com/pydata/xarray/pull/7361#issuecomment-1347554206 https://api.github.com/repos/pydata/xarray/issues/7361 IC_kwDOAMm_X85QUgue spencerkclark 6628425 2022-12-13T00:07:51Z 2022-12-13T00:07:51Z MEMBER

Yes, I think that's what we'll end up going with @mroeschke. Thanks for your patience as we worked it out.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   COMPAT: Adjust CFTimeIndex.get_loc for pandas 2.0 deprecation enforcement 1477931237
1345679164 https://github.com/pydata/xarray/pull/7361#issuecomment-1345679164 https://api.github.com/repos/pydata/xarray/issues/7361 IC_kwDOAMm_X85QNW88 spencerkclark 6628425 2022-12-11T22:50:57Z 2022-12-11T22:50:57Z MEMBER

Technically I think we would consider get_loc to be public (both due to how it is named and in that it is at least primitively documented). That said, I don't know how many people use the lower level methods of CFTimeIndexes like get_loc outside of xarray data structures.

My inclination is that it would not require a deprecation cycle, given the warning had already been being raised as in the example above. It's true though that this warning was not being emitted in the case that key was a string, so perhaps it's a little borderline. Maybe @dcherian or @mathause, do you have any thoughts?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   COMPAT: Adjust CFTimeIndex.get_loc for pandas 2.0 deprecation enforcement 1477931237

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);