issue_comments

Table actions

2 rows where author_association = "MEMBER", issue = 1404894283 and user = 14808389 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • keewis · 2 ✖

issue 1

  • use a hook to synchronize the versions of `black` · 2 ✖

author_association 1

  • MEMBER · 2 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1275128173 https://github.com/pydata/xarray/pull/7153#issuecomment-1275128173 https://api.github.com/repos/pydata/xarray/issues/7153 IC_kwDOAMm_X85MAOlt keewis 14808389 2022-10-11T18:48:01Z 2022-10-11T19:26:48Z MEMBER

yeah, external dependency management is a bit of a pain with pre-commit, and unfortunately that is unlikely to change.

Does pre-commit support additional_dependencies defined by the hook?

it does not complain, but I don't think it does anything with that (though I didn't verify). Also, I don't really want to issue basically empty releases just for pre-commit (even though technically feasible), so the only option I can see is indeed the status quo.

Edit: actually, no, it does make use of additional_dependencies. There's a NamedTuple that will contain all that information, and setting something in .pre-commit-config.yaml will overwrite the default values set in the hook definition.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   use a hook to synchronize the versions of `black` 1404894283
1275074881 https://github.com/pydata/xarray/pull/7153#issuecomment-1275074881 https://api.github.com/repos/pydata/xarray/issues/7153 IC_kwDOAMm_X85MABlB keewis 14808389 2022-10-11T18:00:30Z 2022-10-11T18:00:59Z MEMBER

no, it's just that I don't think blackdoc will have a release cycle that's anything close to black's (every two months, judging by the last two releases), so unless a black release breaks blackdoc (which I hope it won't / have a CI to guard against), I think it's better to keep pinning in the user's configuration.

Unless you meant that black should be installed together with blackdoc? If that was the question: it already is, but will only be updated together with blackdoc, so now that I think of it that might actually make pinning in blackdoc redundant?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   use a hook to synchronize the versions of `black` 1404894283

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);