issue_comments: 1275128173

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/7153#issuecomment-1275128173 https://api.github.com/repos/pydata/xarray/issues/7153 1275128173 IC_kwDOAMm_X85MAOlt 14808389 2022-10-11T18:48:01Z 2022-10-11T19:26:48Z MEMBER

yeah, external dependency management is a bit of a pain with pre-commit, and unfortunately that is unlikely to change.

Does pre-commit support additional_dependencies defined by the hook?

it does not complain, but I don't think it does anything with that (though I didn't verify). Also, I don't really want to issue basically empty releases just for pre-commit (even though technically feasible), so the only option I can see is indeed the status quo.

Edit: actually, no, it does make use of additional_dependencies. There's a NamedTuple that will contain all that information, and setting something in .pre-commit-config.yaml will overwrite the default values set in the hook definition.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   1404894283