issue_comments

Table actions

4 rows where author_association = "MEMBER" and issue = 130767608 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

issue 1

  • BUG: reindexing an array with complex values should keep dtype=complex · 4 ✖

author_association 1

  • MEMBER · 4 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
180097355 https://github.com/pydata/xarray/pull/743#issuecomment-180097355 https://api.github.com/repos/pydata/xarray/issues/743 MDEyOklzc3VlQ29tbWVudDE4MDA5NzM1NQ== shoyer 1217238 2016-02-04T23:13:08Z 2016-02-04T23:13:08Z MEMBER

Looks great -- thanks!

Next time, it's better to give your commits are more descriptive title, and keep GH issue numbers to the commit comments.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   BUG: reindexing an array with complex values should keep dtype=complex 130767608
179487814 https://github.com/pydata/xarray/pull/743#issuecomment-179487814 https://api.github.com/repos/pydata/xarray/issues/743 MDEyOklzc3VlQ29tbWVudDE3OTQ4NzgxNA== shoyer 1217238 2016-02-03T21:49:21Z 2016-02-03T21:49:21Z MEMBER

Looks good to me, assuming tests pass. Could you please squash your commits into one? http://pandas.pydata.org/pandas-docs/stable/contributing.html#combining-commits

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   BUG: reindexing an array with complex values should keep dtype=complex 130767608
178993566 https://github.com/pydata/xarray/pull/743#issuecomment-178993566 https://api.github.com/repos/pydata/xarray/issues/743 MDEyOklzc3VlQ29tbWVudDE3ODk5MzU2Ng== shoyer 1217238 2016-02-03T04:15:41Z 2016-02-03T04:15:41Z MEMBER

Could you also please add a brief change note item to whats-new.rst under 0.7.1?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   BUG: reindexing an array with complex values should keep dtype=complex 130767608
178993172 https://github.com/pydata/xarray/pull/743#issuecomment-178993172 https://api.github.com/repos/pydata/xarray/issues/743 MDEyOklzc3VlQ29tbWVudDE3ODk5MzE3Mg== shoyer 1217238 2016-02-03T04:14:39Z 2016-02-03T04:14:39Z MEMBER

This also needs a test. I would recommend adding a regression test in test_reindex (https://github.com/pydata/xarray/blob/v0.7.0/xarray/test/test_dataarray.py#L622) to verify that complex valued arrays keep a complex dtype when indexed. You can use the example you provided for the github issue for this.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   BUG: reindexing an array with complex values should keep dtype=complex 130767608

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);