home / github / issue_comments

Menu
  • GraphQL API
  • Search all tables

issue_comments: 178993172

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/743#issuecomment-178993172 https://api.github.com/repos/pydata/xarray/issues/743 178993172 MDEyOklzc3VlQ29tbWVudDE3ODk5MzE3Mg== 1217238 2016-02-03T04:14:39Z 2016-02-03T04:14:39Z MEMBER

This also needs a test. I would recommend adding a regression test in test_reindex (https://github.com/pydata/xarray/blob/v0.7.0/xarray/test/test_dataarray.py#L622) to verify that complex valued arrays keep a complex dtype when indexed. You can use the example you provided for the github issue for this.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  130767608
Powered by Datasette · Queries took 0.729ms · About: xarray-datasette