issue_comments

Table actions

9 rows where author_association = "MEMBER" and issue = 106562046 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

issue 1

  • 1D line plot with data on the x axis · 9 ✖

author_association 1

  • MEMBER · 9 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
366743090 https://github.com/pydata/xarray/issues/575#issuecomment-366743090 https://api.github.com/repos/pydata/xarray/issues/575 MDEyOklzc3VlQ29tbWVudDM2Njc0MzA5MA== dcherian 2448579 2018-02-19T16:29:09Z 2018-02-19T16:29:09Z MEMBER

@kuchaale Thanks!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   1D line plot with data on the x axis 106562046
366542983 https://github.com/pydata/xarray/issues/575#issuecomment-366542983 https://api.github.com/repos/pydata/xarray/issues/575 MDEyOklzc3VlQ29tbWVudDM2NjU0Mjk4Mw== dcherian 2448579 2018-02-18T20:01:18Z 2018-02-18T20:01:18Z MEMBER

@kuchaale I see you have an open PR. Are you planning to revisit this soon? If not, I'd like to build off what you started and tackle this bit (not the Dataset method)

In a first step at least, we could add the x and y arguments to the line plot method to make the API consistent with the 2d plot methods (http://xarray.pydata.org/en/latest/api.html#plotting).

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   1D line plot with data on the x axis 106562046
341587358 https://github.com/pydata/xarray/issues/575#issuecomment-341587358 https://api.github.com/repos/pydata/xarray/issues/575 MDEyOklzc3VlQ29tbWVudDM0MTU4NzM1OA== shoyer 1217238 2017-11-02T23:25:23Z 2017-11-02T23:25:23Z MEMBER

In a first step at least, we could add the x and y arguments to the line plot method to make the API consistent with the 2d plot methods

If an argument is a 1D DataArray, how do we indicate this array's data? The best I can think of is to use some sort of sentinel value, maybe None: df.f.plot(x=None, y='z')

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   1D line plot with data on the x axis 106562046
341383768 https://github.com/pydata/xarray/issues/575#issuecomment-341383768 https://api.github.com/repos/pydata/xarray/issues/575 MDEyOklzc3VlQ29tbWVudDM0MTM4Mzc2OA== fmaussion 10050469 2017-11-02T10:47:26Z 2017-11-02T10:47:26Z MEMBER

In a first step at least, we could add the x and y arguments to the line plot method to make the API consistent with the 2d plot methods (http://xarray.pydata.org/en/latest/api.html#plotting). But now that I think of it, they should be kwargs, not args

I wonder if it makes more sense to make .plot() a Dataset method as well

Yes. This might be a bit of an undertaking as there will be several possible cases to handle but this is a good idea!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   1D line plot with data on the x axis 106562046
341178561 https://github.com/pydata/xarray/issues/575#issuecomment-341178561 https://api.github.com/repos/pydata/xarray/issues/575 MDEyOklzc3VlQ29tbWVudDM0MTE3ODU2MQ== shoyer 1217238 2017-11-01T17:29:50Z 2017-11-01T17:29:50Z MEMBER

I wonder if it makes more sense to make .plot() a Dataset method as well, so we could write things like ds.plot.line(x='f', y='z') and ds.plot.scatter(x='f', y='z'). Writing ds.f.plot(orient='h') is much less self-explanatory.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   1D line plot with data on the x axis 106562046
140928503 https://github.com/pydata/xarray/issues/575#issuecomment-140928503 https://api.github.com/repos/pydata/xarray/issues/575 MDEyOklzc3VlQ29tbWVudDE0MDkyODUwMw== jhamman 2443309 2015-09-16T23:56:00Z 2015-09-16T23:56:00Z MEMBER

I'm fine with orient={h, v} but I will offer a few other alternatives. - Explicit is better than implicit. I know what h and v mean but it is more explicit to say horizontal or vertical. These keywords also require less in terms of documentation. - Can we only imagine two options for the orientation? If so, maybe a True/False keyword is a better way to go (orient_horizontal=True)? Maybe not?

I'm not married to either of the opinions I just mentioned, just a few thoughts.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   1D line plot with data on the x axis 106562046
140918753 https://github.com/pydata/xarray/issues/575#issuecomment-140918753 https://api.github.com/repos/pydata/xarray/issues/575 MDEyOklzc3VlQ29tbWVudDE0MDkxODc1Mw== rabernat 1197350 2015-09-16T22:53:05Z 2015-09-16T22:53:05Z MEMBER

Yes, :+1: orient.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   1D line plot with data on the x axis 106562046
140585169 https://github.com/pydata/xarray/issues/575#issuecomment-140585169 https://api.github.com/repos/pydata/xarray/issues/575 MDEyOklzc3VlQ29tbWVudDE0MDU4NTE2OQ== clarkfitzg 5356122 2015-09-16T00:11:28Z 2015-09-16T00:11:28Z MEMBER

Not possible now. Wouldn't be much trouble to add it though. @drewokane has been working on generalizing the 1d plotting in #566. This might be a nice thing to include.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   1D line plot with data on the x axis 106562046
140556487 https://github.com/pydata/xarray/issues/575#issuecomment-140556487 https://api.github.com/repos/pydata/xarray/issues/575 MDEyOklzc3VlQ29tbWVudDE0MDU1NjQ4Nw== shoyer 1217238 2015-09-15T21:48:40Z 2015-09-15T21:48:40Z MEMBER

I don't think we have an easy way to do this now.

Seaborn uses the keyword argument orient='h' or orient='v' to control orientation for categorical plots like violinplot. That might be a reasonable API to emulate here.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   1D line plot with data on the x axis 106562046

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);