home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 140928503

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/575#issuecomment-140928503 https://api.github.com/repos/pydata/xarray/issues/575 140928503 MDEyOklzc3VlQ29tbWVudDE0MDkyODUwMw== 2443309 2015-09-16T23:56:00Z 2015-09-16T23:56:00Z MEMBER

I'm fine with orient={h, v} but I will offer a few other alternatives. - Explicit is better than implicit. I know what h and v mean but it is more explicit to say horizontal or vertical. These keywords also require less in terms of documentation. - Can we only imagine two options for the orientation? If so, maybe a True/False keyword is a better way to go (orient_horizontal=True)? Maybe not?

I'm not married to either of the opinions I just mentioned, just a few thoughts.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  106562046
Powered by Datasette · Queries took 0.918ms · About: xarray-datasette