issue_comments

Table actions

5 rows where author_association = "MEMBER", issue = 1046990273 and user = 2448579 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • dcherian · 5 ✖

issue 1

  • Generate reductions for DataArray, Dataset, GroupBy and Resample · 5 ✖

author_association 1

  • MEMBER · 5 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1062165764 https://github.com/pydata/xarray/pull/5950#issuecomment-1062165764 https://api.github.com/repos/pydata/xarray/issues/5950 IC_kwDOAMm_X84_T10E dcherian 2448579 2022-03-08T20:11:14Z 2022-03-08T20:11:14Z MEMBER

@shoyer can you take a look at the approach here? I'd like to finish this off soon.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Generate reductions for DataArray, Dataset, GroupBy and Resample 1046990273
979692571 https://github.com/pydata/xarray/pull/5950#issuecomment-979692571 https://api.github.com/repos/pydata/xarray/issues/5950 IC_kwDOAMm_X846ZOwb dcherian 2448579 2021-11-26T04:41:07Z 2021-11-26T04:41:07Z MEMBER

My request was for #5734 but after merging the latest version of this branch, it passes! Thanks for checking.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Generate reductions for DataArray, Dataset, GroupBy and Resample 1046990273
974714832 https://github.com/pydata/xarray/pull/5950#issuecomment-974714832 https://api.github.com/repos/pydata/xarray/issues/5950 IC_kwDOAMm_X846GPfQ dcherian 2448579 2021-11-20T21:36:40Z 2021-11-20T21:36:40Z MEMBER

Thanks @Illviljan

a slightly breaking change now since some of these reduce functions had quite different arguments.

Can you describe these changes please? Is it the switch to keyword-only?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Generate reductions for DataArray, Dataset, GroupBy and Resample 1046990273
974687406 https://github.com/pydata/xarray/pull/5950#issuecomment-974687406 https://api.github.com/repos/pydata/xarray/issues/5950 IC_kwDOAMm_X846GIyu dcherian 2448579 2021-11-20T17:57:16Z 2021-11-20T17:58:12Z MEMBER

still failing :( xarray/core/groupby.py:881: error: Definition of "reduce" in base class "DataArrayGroupByBase" is incompatible with definition in base class "DataArrayGroupByReductions" [misc] xarray/core/groupby.py:1004: error: Definition of "reduce" in base class "DatasetGroupByBase" is incompatible with definition in base class "DatasetGroupByReductions" [misc] xarray/core/dataset.py:4999: error: Argument 3 of "reduce" is incompatible with supertype "DatasetReductions"; supertype defines the argument type as "Union[int, Sequence[int], None]" [override] xarray/core/dataset.py:4999: note: This violates the Liskov substitution principle xarray/core/dataset.py:4999: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#incompatible-overrides xarray/core/dataset.py:4999: error: Argument 4 of "reduce" is incompatible with supertype "DatasetReductions"; supertype defines the argument type as "Optional[bool]" [override] xarray/core/resample.py:160: error: Definition of "reduce" in base class "DataArrayGroupByBase" is incompatible with definition in base class "DataArrayResampleReductions" [misc] Found 5 errors in 3 files (checked 2 source files)

I'vebeen using Usage: python xarray/util/generate_reductions.py > xarray/core/_reductions.py pytest --doctest-modules xarray/core/_reductions.py --accept || true pytest --doctest-modules xarray/core/_reductions.py to generate the file

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Generate reductions for DataArray, Dataset, GroupBy and Resample 1046990273
963399639 https://github.com/pydata/xarray/pull/5950#issuecomment-963399639 https://api.github.com/repos/pydata/xarray/issues/5950 IC_kwDOAMm_X845bE_X dcherian 2448579 2021-11-08T17:37:39Z 2021-11-08T17:37:39Z MEMBER

Could use some help with typing...

xarray/tests/test_groupby.py:77: error: Invalid self argument "Dataset" to attribute function "sum" with type "Callable[[DatasetReduce, Optional[Hashable], Optional[bool], Optional[int], Optional[bool], KwArg(Any)], T_Dataset]" [misc] xarray/tests/test_groupby.py:77: error: Need type annotation for "expected" [var-annotated] xarray/tests/test_groupby.py:460: error: Invalid self argument "Dataset" to attribute function "mean" with type "Callable[[DatasetReduce, Optional[Hashable], Optional[bool], Optional[bool], KwArg(Any)], T_Dataset]" [misc] xarray/tests/test_groupby.py:460: error: <nothing> has no attribute "where" [attr-defined] xarray/tests/test_groupby.py:646: error: Invalid self argument "Dataset" to attribute function "mean" with type "Callable[[DatasetReduce, Optional[Hashable], Optional[bool], Optional[bool], KwArg(Any)], T_Dataset]" [misc] xarray/tests/test_groupby.py:646: error: Need type annotation for "expected" [var-annotated] xarray/tests/test_groupby.py:658: error: Invalid self argument "DataArray" to attribute function "mean" with type "Callable[[DataArrayReduce, Optional[Hashable], Optional[bool], Optional[bool], KwArg(Any)], T_DataArray]" [misc] xarray/tests/test_groupby.py:658: error: <nothing> has no attribute "variable" [attr-defined] xarray/tests/test_computation.py:1867: error: Invalid self argument "DataArray" to attribute function "sum" with type "Callable[[DataArrayReduce, Optional[Hashable], Optional[bool], Optional[int], Optional[bool], KwArg(Any)], T_DataArray]" [misc] xarray/tests/test_computation.py:1867: error: Need type annotation for "expected" [var-annotated] xarray/tests/test_computation.py:1867: error: Argument 1 to "sum" of "DataArrayReductions" has incompatible type "List[str]"; expected "Optional[Hashable]" [arg-type] xarray/tests/test_computation.py:1867: note: Following member(s) of "List[str]" have conflicts: xarray/tests/test_computation.py:1867: note: __hash__: expected "Callable[[], int]", got "None" xarray/tests/test_computation.py:1871: error: Invalid self argument "DataArray" to attribute function "sum" with type "Callable[[DataArrayReduce, Optional[Hashable], Optional[bool], Optional[int], Optional[bool], KwArg(Any)], T_DataArray]" [misc] xarray/tests/test_computation.py:1882: error: Invalid self argument "DataArray" to attribute function "sum" with type "Callable[[DataArrayReduce, Optional[Hashable], Optional[bool], Optional[int], Optional[bool], KwArg(Any)], T_DataArray]" [misc] xarray/tests/test_computation.py:1882: error: Argument 1 to "sum" of "DataArrayReductions" has incompatible type "List[str]"; expected "Optional[Hashable]" [arg-type] xarray/tests/test_computation.py:1882: note: Following member(s) of "List[str]" have conflicts: xarray/tests/test_computation.py:1882: note: __hash__: expected "Callable[[], int]", got "None" xarray/tests/test_computation.py:1887: error: Invalid self argument "DataArray" to attribute function "sum" with type "Callable[[DataArrayReduce, Optional[Hashable], Optional[bool], Optional[int], Optional[bool], KwArg(Any)], T_DataArray]" [misc] xarray/tests/test_computation.py:1887: error: Argument 1 to "sum" of "DataArrayReductions" has incompatible type "List[str]"; expected "Optional[Hashable]" [arg-type] xarray/tests/test_computation.py:1887: note: Following member(s) of "List[str]" have conflicts: xarray/tests/test_computation.py:1887: note: __hash__: expected "Callable[[], int]", got "None" xarray/tests/test_computation.py:1892: error: Invalid self argument "DataArray" to attribute function "sum" with type "Callable[[DataArrayReduce, Optional[Hashable], Optional[bool], Optional[int], Optional[bool], KwArg(Any)], T_DataArray]" [misc] xarray/tests/test_computation.py:1892: error: Argument 1 to "sum" of "DataArrayReductions" has incompatible type "List[str]"; expected "Optional[Hashable]" [arg-type] xarray/tests/test_computation.py:1892: note: Following member(s) of "List[str]" have conflicts: xarray/tests/test_computation.py:1892: note: __hash__: expected "Callable[[], int]", got "None"

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Generate reductions for DataArray, Dataset, GroupBy and Resample 1046990273

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);