issue_comments: 974687406

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/5950#issuecomment-974687406 https://api.github.com/repos/pydata/xarray/issues/5950 974687406 IC_kwDOAMm_X846GIyu 2448579 2021-11-20T17:57:16Z 2021-11-20T17:58:12Z MEMBER

still failing :( xarray/core/groupby.py:881: error: Definition of "reduce" in base class "DataArrayGroupByBase" is incompatible with definition in base class "DataArrayGroupByReductions" [misc] xarray/core/groupby.py:1004: error: Definition of "reduce" in base class "DatasetGroupByBase" is incompatible with definition in base class "DatasetGroupByReductions" [misc] xarray/core/dataset.py:4999: error: Argument 3 of "reduce" is incompatible with supertype "DatasetReductions"; supertype defines the argument type as "Union[int, Sequence[int], None]" [override] xarray/core/dataset.py:4999: note: This violates the Liskov substitution principle xarray/core/dataset.py:4999: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#incompatible-overrides xarray/core/dataset.py:4999: error: Argument 4 of "reduce" is incompatible with supertype "DatasetReductions"; supertype defines the argument type as "Optional[bool]" [override] xarray/core/resample.py:160: error: Definition of "reduce" in base class "DataArrayGroupByBase" is incompatible with definition in base class "DataArrayResampleReductions" [misc] Found 5 errors in 3 files (checked 2 source files)

I'vebeen using Usage: python xarray/util/generate_reductions.py > xarray/core/_reductions.py pytest --doctest-modules xarray/core/_reductions.py --accept || true pytest --doctest-modules xarray/core/_reductions.py to generate the file

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   1046990273