issue_comments

Table actions

5 rows where author_association = "MEMBER" and issue = 1046454702 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

issue 1

  • Backend / plugin system `remove_duplicates` raises AttributeError on discovering duplicates · 5 ✖

author_association 1

  • MEMBER · 5 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
964166418 https://github.com/pydata/xarray/issues/5944#issuecomment-964166418 https://api.github.com/repos/pydata/xarray/issues/5944 IC_kwDOAMm_X845eAMS kmuehlbauer 5821660 2021-11-09T13:47:08Z 2021-11-09T13:47:08Z MEMBER

OK, here are my findings.

There are tests for this in https://github.com/pydata/xarray/blob/main/xarray/tests/test_plugins.py, but they are still using pkg_resources. Because of that, the tests did not capture this issue although we have tests for it.

While fixing the AttributeError the tests finally failed (it was using pkg_resources nomenclature).

With latest #5959 everything should be in place now.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Backend / plugin system `remove_duplicates` raises AttributeError on discovering duplicates 1046454702
963910158 https://github.com/pydata/xarray/issues/5944#issuecomment-963910158 https://api.github.com/repos/pydata/xarray/issues/5944 IC_kwDOAMm_X845dBoO kmuehlbauer 5821660 2021-11-09T08:16:23Z 2021-11-09T08:16:23Z MEMBER

@snowman2 #5959 should fix the AttributeError: 'EntryPoint' object has no attribute 'module_name'.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Backend / plugin system `remove_duplicates` raises AttributeError on discovering duplicates 1046454702
963573691 https://github.com/pydata/xarray/issues/5944#issuecomment-963573691 https://api.github.com/repos/pydata/xarray/issues/5944 IC_kwDOAMm_X845bve7 kmuehlbauer 5821660 2021-11-08T21:07:26Z 2021-11-08T21:07:26Z MEMBER

@snowman2 Do you get the same error when running the testsuite for rioxarray with xarray 0.20.1?

My question would be, why are those duplicates there in the first place. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Backend / plugin system `remove_duplicates` raises AttributeError on discovering duplicates 1046454702
963061544 https://github.com/pydata/xarray/issues/5944#issuecomment-963061544 https://api.github.com/repos/pydata/xarray/issues/5944 IC_kwDOAMm_X845Zyco kmuehlbauer 5821660 2021-11-08T11:31:03Z 2021-11-08T11:31:03Z MEMBER

@weiji14 I've solved my issue by invoking pytest with --import-mode="append" outside the package directory.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Backend / plugin system `remove_duplicates` raises AttributeError on discovering duplicates 1046454702
962997871 https://github.com/pydata/xarray/issues/5944#issuecomment-962997871 https://api.github.com/repos/pydata/xarray/issues/5944 IC_kwDOAMm_X845Zi5v kmuehlbauer 5821660 2021-11-08T10:10:30Z 2021-11-08T10:10:30Z MEMBER

@ashwinvis @weiji14 I've encountered the same problem. As there is possibly a bug in remove_duplicates, another issue is hidden deeper.

https://github.com/pydata/xarray/blob/e0deb9cf0a5cd5c9e3db033fd13f075added9c1e/xarray/backends/plugins.py#L100-L103

Here entry_points is called and for some reason it returns the xarray.backends twice (but only if invoked via pytest). This can be followed down to importlib/metadata.py distributions() which finds the package under test twice. This is as far as I could get.

Any help very much appreciated.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Backend / plugin system `remove_duplicates` raises AttributeError on discovering duplicates 1046454702

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);